fix: output.clean can not remove *.hot-update.js #3689

jerrykingxyz · 2023-07-03T10:23:15Z

Summary

change compilation.emitted_asset_versions to HashMap
compilation.emitted_asset_versions will save all of emitted assets contains version is empty.
emit_assets will regenerate compilation.emitted_asset_versions

Added a e2e test case to ensure results are as expected.

crates/rspack_core/src/compiler/mod.rs

jerrykingxyz requested a review from h-a-n-a as a code owner July 3, 2023 10:23

jerrykingxyz requested a review from a team July 3, 2023 10:23

jerrykingxyz requested a review from Boshen as a code owner July 3, 2023 10:23

jerrykingxyz requested a review from underfin July 3, 2023 10:23

github-actions bot added release: bug fix team The issue/pr is created by the member of Rspack. labels Jul 3, 2023

underfin reviewed Jul 3, 2023

View reviewed changes

crates/rspack_core/src/compiler/mod.rs Outdated Show resolved Hide resolved

fix: output.clean can not remove hot-update.js

3e277b1

jerrykingxyz force-pushed the jerry/clean branch from 54d1a72 to 3e277b1 Compare July 3, 2023 10:58

underfin approved these changes Jul 3, 2023

View reviewed changes

jerrykingxyz enabled auto-merge July 3, 2023 11:03

jerrykingxyz added this pull request to the merge queue Jul 3, 2023

Merged via the queue into main with commit a5f739f Jul 3, 2023
17 of 19 checks passed

jerrykingxyz deleted the jerry/clean branch July 3, 2023 12:16