fix: should not create additional missing modules #5124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: feature
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
github-actions
bot
added
the
team
h-a-n-a
force-pushed
the
12-26-feat_add_resolve_errors
branch
from
e8af080
to
169a83f
Compare
h-a-n-a
force-pushed
the
12-26-feat_add_resolve_errors
branch
from
169a83f
to
8afad27
Compare
|
!canary |
|
0.4.5-canary-b3497fe-20231227113840 |
h-a-n-a
changed the title
github-actions
bot
added
release: bug fix
2 tasks
h-a-n-a
requested review from
LingyuCoder,
ahabhgk,
IWANABETHATGUY and
ScriptedAlchemy
ahabhgk
approved these changes
Dec 27, 2023
This was referenced Dec 27, 2023
IWANABETHATGUY
pushed a commit
that referenced
this pull request
Dec 27, 2023
2 tasks
ahabhgk
pushed a commit
that referenced
this pull request
Jan 2, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on #5084.
closes #5085.
This PR removes the old missing module. To replace the old one, this PR aligns the missing module in code generation stage of each referencing module of the missing modules.
This PR also moves
diagnosticstoModuleFactoryCreateData, asModuleFactoryis singleton ifDependencyTypeis the same to avoid conflicts between different creations.Test Plan
Enabled more compiler tests for
options.bail.Added diagnostic test for
empty-dependency.Require Documentation?