Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: full require in try catch should be optional #5262

Merged
merged 1 commit into from
Jan 8, 2024
Merged

fix: full require in try catch should be optional #5262

merged 1 commit into from
Jan 8, 2024

Conversation

LingyuCoder
Copy link
Collaborator

@LingyuCoder LingyuCoder commented Jan 8, 2024 •
edited
Loading

Summary

Related to comment in #5197, full rqeuire in try catch should be optional

Test Plan

added

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@LingyuCoder LingyuCoder requested review from a team, jerrykingxyz and h-a-n-a January 8, 2024 02:54
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Jan 8, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 8, 2024
@LingyuCoder LingyuCoder mentioned this pull request Jan 8, 2024
Closed
@LingyuCoder
Copy link
Collaborator Author

!eco-ci

@rspack-bot
Copy link

rspack-bot commented Jan 8, 2024 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
nx ✅ success
rspress ✅ success
rsbuild ✅ success
compat ✅ success

@LingyuCoder
Copy link
Collaborator Author

!canary

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

0.4.5-canary-86e1dfe-20240108035532

@LingyuCoder LingyuCoder merged commit d9b4743 into main Jan 8, 2024
22 checks passed
@LingyuCoder LingyuCoder deleted the fix/full-require-optional branch January 8, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSerFeng JSerFeng JSerFeng approved these changes

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

@ahabhgk ahabhgk Awaiting requested review from ahabhgk

Assignees

@LingyuCoder LingyuCoder

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LingyuCoder @rspack-bot @JSerFeng