-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: builtin swc loader input sourcemap #5492
fix: builtin swc loader input sourcemap #5492
Conversation
6376770
to
ad0c219
Compare
Could you add a test? |
2f15a86
to
d0ea54c
Compare
test has been added and passed in my repository see https://github.com/2239559319/rspack/pull/3 but failed in this repository. |
!bench |
📝 Benchmark detail: Open
|
d0ea54c
to
433818c
Compare
✅ Deploy Preview for rspack canceled.
|
❌ Deploy Preview for rspack-back failed. Why did it fail? →
|
packages/rspack/tests/configCases/source-map/srouce-map-loader/index.js
Outdated
Show resolved
Hide resolved
433818c
to
0b352be
Compare
@ahabhgk Can we get a review on this please? |
0b352be
to
cc0a9b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for delay, this is a good catch, thank you!
@hardfist Is this released?the latest version(0.6.5) is still not effective "use strict";
function message() {
console.log('inline-source-map');
}
message();
//# sourceMappingURL=data:application/json;charset=utf-8;base64,eyJ2ZXJzaW9uIjozLCJzb3VyY2VzIjpbImlubGluZS1zb3VyY2UtbWFwLnRzIl0sIm5hbWVzIjpbIm1lc3NhZ2UiLCJjb25zb2xlIiwibG9nIl0sIm1hcHBpbmdzIjoiOztBQUFBLFNBQVNBLE9BQVQsR0FBbUI7QUFDakJDLEVBQUFBLE9BQU8sQ0FBQ0MsR0FBUixDQUFZLG1CQUFaO0FBQ0Q7O0FBRURGLE9BQU8iLCJzb3VyY2VzQ29udGVudCI6WyJmdW5jdGlvbiBtZXNzYWdlKCkge1xuICBjb25zb2xlLmxvZygnaW5saW5lLXNvdXJjZS1tYXAnKTtcbn1cblxubWVzc2FnZSgpO1xuIl19 repo: https://github.com/littleprincewdk/rspack-inputSourceMap-bug-demo |
Summary
fix #5480
std::mem::take
will be replaced with the default value. Therefore, subsequent loaders cannot obtain the correct value.Test Plan
Require Documentation?