Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: runtime module hook after tree runtime requirements #5661

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

LingyuCoder
Copy link
Collaborator

@LingyuCoder LingyuCoder commented Feb 18, 2024

Summary

Fix #5571, run runtime_module hook after runtime_requirements_in_tree to make sure the code generation can use full runtime requirements

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Feb 18, 2024
@LingyuCoder LingyuCoder merged commit caed025 into main Feb 18, 2024
23 checks passed
@LingyuCoder LingyuCoder deleted the fix/runtime-module-hmr branch February 18, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: hmrC.css is missing after the css_loading runtimeModule is changed
2 participants