Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support stage for processAssets #5861

Merged
merged 2 commits into from Mar 7, 2024
Merged

Conversation

ahabhgk
Copy link
Collaborator

@ahabhgk ahabhgk commented Mar 5, 2024

Summary

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@ahabhgk ahabhgk marked this pull request as draft March 5, 2024 12:43
@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Mar 5, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 5, 2024
@ahabhgk ahabhgk marked this pull request as ready for review March 6, 2024 07:17
@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Mar 6, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Mar 6, 2024

📝 Benchmark detail: Open

Name Base (2024-03-05 debe2bc) Current Change
10000_development-mode + exec 1.71 s ± 22 ms 1.68 s ± 12 ms -1.60 %
10000_development-mode_hmr + exec 707 ms ± 5.7 ms 713 ms ± 7.1 ms +0.87 %
10000_production-mode + exec 2.63 s ± 17 ms 2.71 s ± 54 ms +2.81 %
arco-pro_development-mode + exec 2.39 s ± 21 ms 2.43 s ± 25 ms +1.58 %
arco-pro_development-mode_hmr + exec 510 ms ± 4 ms 507 ms ± 9.1 ms -0.45 %
arco-pro_development-mode_hmr_intercept-plugin + exec 524 ms ± 5.4 ms 525 ms ± 5.7 ms +0.26 %
arco-pro_development-mode_intercept-plugin + exec 3.16 s ± 35 ms 3.19 s ± 29 ms +0.80 %
arco-pro_production-mode + exec 4.01 s ± 63 ms 4.11 s ± 28 ms +2.51 %
arco-pro_production-mode_intercept-plugin + exec 4.87 s ± 45 ms 4.81 s ± 85 ms -1.17 %
threejs_development-mode_10x + exec 1.94 s ± 31 ms 1.89 s ± 19 ms -2.84 %
threejs_development-mode_10x_hmr + exec 720 ms ± 5.4 ms 723 ms ± 3.9 ms +0.42 %
threejs_production-mode_10x + exec 5.9 s ± 70 ms 5.81 s ± 102 ms -1.54 %

@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Mar 6, 2024

!eco-ci

@rspack-bot
Copy link

rspack-bot commented Mar 6, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
nx ✅ success
rspress ✅ success
rsbuild ❌ failure
compat ✅ success
examples ✅ success

@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Mar 6, 2024

!eco-ci

@rspack-bot
Copy link

rspack-bot commented Mar 6, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
nx ✅ success
rspress ✅ success
rsbuild ❌ failure
compat ✅ success
examples ✅ success

@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Mar 6, 2024

!eco-ci

@rspack-bot
Copy link

rspack-bot commented Mar 6, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
nx ✅ success
rspress ✅ success
rsbuild ✅ success
compat ✅ success
examples ✅ success

@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Mar 7, 2024

!eco-ci

@rspack-bot
Copy link

rspack-bot commented Mar 7, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
nx ✅ success
rspress ✅ success
rsbuild ✅ success
compat ✅ success
examples ✅ success

@ahabhgk ahabhgk merged commit 90d5371 into main Mar 7, 2024
23 checks passed
@ahabhgk ahabhgk deleted the refactor-process-assets branch March 7, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants