Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support modify resource in after resolve hook #5924

Merged
merged 2 commits into from
Mar 14, 2024
Merged

feat: support modify resource in after resolve hook #5924

merged 2 commits into from
Mar 14, 2024

Conversation

LingyuCoder
Copy link
Collaborator

@LingyuCoder LingyuCoder commented Mar 12, 2024 •
edited

Summary

Relate #5912

  • After resolve hook should run before create module, just like webpack
  • After resolve hook can modify resource and request

Warning: this will result in significant performance regression

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Mar 12, 2024
@LingyuCoder LingyuCoder force-pushed the feat/after-resolve-resource branch 3 times, most recently from 4050aec to 1f35c13 Compare March 13, 2024 07:07
@LingyuCoder LingyuCoder marked this pull request as ready for review March 13, 2024 08:36
@LingyuCoder LingyuCoder requested a review from Boshen March 13, 2024 08:36
@LingyuCoder
Copy link
Collaborator Author

!canary

@github-actions GitHub Actions
Copy link
Contributor

0.5.7-canary-1f35c13-20240313091234

@Boshen Boshen added the need documentation Create a tracking issue in rspack-website label Mar 14, 2024
@rspack-bot rspack-bot mentioned this pull request Mar 14, 2024
Open
@LingyuCoder LingyuCoder enabled auto-merge (squash) March 14, 2024 04:55
@LingyuCoder LingyuCoder merged commit 3c7a0d7 into main Mar 14, 2024
24 of 25 checks passed
@LingyuCoder LingyuCoder deleted the feat/after-resolve-resource branch March 14, 2024 05:01
@Boshen Boshen mentioned this pull request Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen approved these changes

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

@hardfist hardfist Awaiting requested review from hardfist

Assignees

@LingyuCoder LingyuCoder

Labels
need documentation Create a tracking issue in rspack-website release: feature release: feature related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LingyuCoder @Boshen