Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nmf before resolve bench regression #5941

Merged
merged 7 commits into from
Mar 14, 2024
Merged

fix: nmf before resolve bench regression #5941

merged 7 commits into from
Mar 14, 2024

Conversation

ahabhgk
Copy link
Collaborator

@ahabhgk ahabhgk commented Mar 14, 2024

Summary

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Mar 14, 2024
@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Mar 14, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Mar 14, 2024

📝 Benchmark detail: Open

Name Base (2024-03-14 769ca8e) Current Change
10000_development-mode + exec 1.74 s ± 19 ms 2.87 s ± 49 ms +64.85 %
10000_development-mode_hmr + exec 723 ms ± 9.4 ms 740 ms ± 9.3 ms +2.32 %
10000_production-mode + exec 2.67 s ± 27 ms 3.55 s ± 89 ms +33.37 %
arco-pro_development-mode + exec 3.04 s ± 20 ms 2.46 s ± 24 ms -19.03 %
arco-pro_development-mode_hmr + exec 510 ms ± 2.8 ms 514 ms ± 3.2 ms +0.71 %
arco-pro_development-mode_hmr_intercept-plugin + exec 524 ms ± 16 ms 524 ms ± 27 ms -0.06 %
arco-pro_development-mode_intercept-plugin + exec 3.32 s ± 104 ms 3.34 s ± 80 ms +0.56 %
arco-pro_production-mode + exec 4.64 s ± 40 ms 4.07 s ± 22 ms -12.24 %
arco-pro_production-mode_intercept-plugin + exec 4.89 s ± 44 ms 4.98 s ± 56 ms +1.70 %
threejs_development-mode_10x + exec 1.82 s ± 33 ms 1.86 s ± 24 ms +2.10 %
threejs_development-mode_10x_hmr + exec 728 ms ± 6 ms 755 ms ± 8.5 ms +3.74 %
threejs_production-mode_10x + exec 5.8 s ± 64 ms 5.88 s ± 61 ms +1.26 %

Threshold exceeded: ["10000_development-mode + exec","10000_production-mode + exec"]

@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Mar 14, 2024

!eco-ci

@rspack-bot
Copy link

rspack-bot commented Mar 14, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
nx ✅ success
rspress ✅ success
rsbuild ✅ success
compat ✅ success
examples ✅ success

@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Mar 14, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Mar 14, 2024

📝 Benchmark detail: Open

Name Base (2024-03-14 769ca8e) Current Change
10000_development-mode + exec 1.74 s ± 19 ms 2.84 s ± 25 ms +62.85 %
10000_development-mode_hmr + exec 723 ms ± 9.4 ms 732 ms ± 4.8 ms +1.17 %
10000_production-mode + exec 2.67 s ± 27 ms 3.47 s ± 43 ms +30.32 %
arco-pro_development-mode + exec 3.04 s ± 20 ms 2.47 s ± 48 ms -18.69 %
arco-pro_development-mode_hmr + exec 510 ms ± 2.8 ms 511 ms ± 3.1 ms +0.20 %
arco-pro_development-mode_hmr_intercept-plugin + exec 524 ms ± 16 ms 530 ms ± 5.6 ms +1.18 %
arco-pro_development-mode_intercept-plugin + exec 3.32 s ± 104 ms 3.41 s ± 71 ms +2.68 %
arco-pro_production-mode + exec 4.64 s ± 40 ms 4.09 s ± 49 ms -11.91 %
arco-pro_production-mode_intercept-plugin + exec 4.89 s ± 44 ms 4.97 s ± 71 ms +1.51 %
threejs_development-mode_10x + exec 1.82 s ± 33 ms 1.87 s ± 21 ms +2.66 %
threejs_development-mode_10x_hmr + exec 728 ms ± 6 ms 751 ms ± 5.5 ms +3.22 %
threejs_production-mode_10x + exec 5.8 s ± 64 ms 5.66 s ± 41 ms -2.58 %

Threshold exceeded: ["10000_development-mode + exec","10000_production-mode + exec"]

@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Mar 14, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Mar 14, 2024

📝 Benchmark detail: Open

Name Base (2024-03-14 769ca8e) Current Change
10000_development-mode + exec 1.74 s ± 19 ms 2.84 s ± 29 ms +63.13 %
10000_development-mode_hmr + exec 723 ms ± 9.4 ms 741 ms ± 12 ms +2.44 %
10000_production-mode + exec 2.67 s ± 27 ms 3.53 s ± 56 ms +32.43 %
arco-pro_development-mode + exec 3.04 s ± 20 ms 2.48 s ± 26 ms -18.43 %
arco-pro_development-mode_hmr + exec 510 ms ± 2.8 ms 513 ms ± 5.1 ms +0.52 %
arco-pro_development-mode_hmr_intercept-plugin + exec 524 ms ± 16 ms 527 ms ± 4.7 ms +0.57 %
arco-pro_development-mode_intercept-plugin + exec 3.32 s ± 104 ms 3.38 s ± 64 ms +1.90 %
arco-pro_production-mode + exec 4.64 s ± 40 ms 4.1 s ± 30 ms -11.73 %
arco-pro_production-mode_intercept-plugin + exec 4.89 s ± 44 ms 5.09 s ± 100 ms +3.90 %
threejs_development-mode_10x + exec 1.82 s ± 33 ms 1.9 s ± 31 ms +4.60 %
threejs_development-mode_10x_hmr + exec 728 ms ± 6 ms 758 ms ± 6.9 ms +4.13 %
threejs_production-mode_10x + exec 5.8 s ± 64 ms 5.84 s ± 43 ms +0.63 %

Threshold exceeded: ["10000_development-mode + exec","10000_production-mode + exec"]

@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Mar 14, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Mar 14, 2024

📝 Benchmark detail: Open

Name Base (2024-03-14 769ca8e) Current Change
10000_development-mode + exec 1.74 s ± 19 ms 1.93 s ± 18 ms +10.79 %
10000_development-mode_hmr + exec 723 ms ± 9.4 ms 744 ms ± 2.3 ms +2.91 %
10000_production-mode + exec 2.67 s ± 27 ms 2.98 s ± 47 ms +11.75 %
arco-pro_development-mode + exec 3.04 s ± 20 ms 2.54 s ± 32 ms -16.50 %
arco-pro_development-mode_hmr + exec 510 ms ± 2.8 ms 514 ms ± 2.1 ms +0.75 %
arco-pro_development-mode_hmr_intercept-plugin + exec 524 ms ± 16 ms 530 ms ± 4.9 ms +1.12 %
arco-pro_development-mode_intercept-plugin + exec 3.32 s ± 104 ms 3.37 s ± 32 ms +1.44 %
arco-pro_production-mode + exec 4.64 s ± 40 ms 4.18 s ± 49 ms -9.95 %
arco-pro_production-mode_intercept-plugin + exec 4.89 s ± 44 ms 5.07 s ± 104 ms +3.54 %
threejs_development-mode_10x + exec 1.82 s ± 33 ms 1.89 s ± 23 ms +3.93 %
threejs_development-mode_10x_hmr + exec 728 ms ± 6 ms 742 ms ± 8.6 ms +1.88 %
threejs_production-mode_10x + exec 5.8 s ± 64 ms 5.83 s ± 74 ms +0.42 %

Threshold exceeded: ["10000_development-mode + exec","10000_production-mode + exec"]

@ahabhgk ahabhgk enabled auto-merge (squash) March 14, 2024 11:45
@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Mar 14, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Mar 14, 2024

📝 Benchmark detail: Open

Name Base (2024-03-14 769ca8e) Current Change
10000_development-mode + exec 1.74 s ± 19 ms 1.93 s ± 15 ms +10.62 %
10000_development-mode_hmr + exec 723 ms ± 9.4 ms 732 ms ± 11 ms +1.26 %
10000_production-mode + exec 2.67 s ± 27 ms 2.81 s ± 30 ms +5.39 %
arco-pro_development-mode + exec 3.04 s ± 20 ms 2.48 s ± 24 ms -18.40 %
arco-pro_development-mode_hmr + exec 510 ms ± 2.8 ms 514 ms ± 2.6 ms +0.76 %
arco-pro_development-mode_hmr_intercept-plugin + exec 524 ms ± 16 ms 528 ms ± 3.8 ms +0.77 %
arco-pro_development-mode_intercept-plugin + exec 3.32 s ± 104 ms 3.32 s ± 39 ms -0.02 %
arco-pro_production-mode + exec 4.64 s ± 40 ms 4.19 s ± 47 ms -9.75 %
arco-pro_production-mode_intercept-plugin + exec 4.89 s ± 44 ms 5.08 s ± 33 ms +3.69 %
threejs_development-mode_10x + exec 1.82 s ± 33 ms 1.92 s ± 20 ms +5.63 %
threejs_development-mode_10x_hmr + exec 728 ms ± 6 ms 736 ms ± 11 ms +1.12 %
threejs_production-mode_10x + exec 5.8 s ± 64 ms 5.88 s ± 55 ms +1.28 %

Threshold exceeded: ["10000_development-mode + exec","10000_production-mode + exec","threejs_development-mode_10x + exec"]

@ahabhgk ahabhgk merged commit 071a1ef into main Mar 14, 2024
22 of 24 checks passed
@ahabhgk ahabhgk deleted the fix-reg branch March 14, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants