Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: build module hook #5980

Merged
merged 1 commit into from
Mar 20, 2024
Merged

refactor: build module hook #5980

merged 1 commit into from
Mar 20, 2024

Conversation

ahabhgk
Copy link
Collaborator

@ahabhgk ahabhgk commented Mar 20, 2024

Summary

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@ahabhgk ahabhgk requested a review from hardfist as a code owner March 20, 2024 09:08
@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Mar 20, 2024

!bench

@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Mar 20, 2024

!eco-ci

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 20, 2024
@rspack-bot
Copy link

rspack-bot commented Mar 20, 2024

📝 Benchmark detail: Open

Name Base (2024-03-20 afdf730) Current Change
10000_development-mode + exec 2.02 s ± 34 ms 1.93 s ± 17 ms -4.22 %
10000_development-mode_hmr + exec 744 ms ± 8.2 ms 737 ms ± 4.2 ms -0.91 %
10000_production-mode + exec 2.82 s ± 23 ms 2.81 s ± 30 ms -0.21 %
arco-pro_development-mode + exec 2.48 s ± 32 ms 2.46 s ± 34 ms -0.62 %
arco-pro_development-mode_hmr + exec 516 ms ± 5 ms 512 ms ± 0.51 ms -0.90 %
arco-pro_development-mode_hmr_intercept-plugin + exec 533 ms ± 7.8 ms 529 ms ± 4.2 ms -0.88 %
arco-pro_development-mode_intercept-plugin + exec 3.3 s ± 27 ms 3.3 s ± 30 ms -0.24 %
arco-pro_production-mode + exec 4.23 s ± 46 ms 4.08 s ± 25 ms -3.65 %
arco-pro_production-mode_intercept-plugin + exec 5.06 s ± 38 ms 4.94 s ± 39 ms -2.38 %
threejs_development-mode_10x + exec 1.91 s ± 17 ms 1.89 s ± 21 ms -1.39 %
threejs_development-mode_10x_hmr + exec 739 ms ± 6.9 ms 736 ms ± 5.2 ms -0.36 %
threejs_production-mode_10x + exec 5.95 s ± 70 ms 5.87 s ± 54 ms -1.39 %

@rspack-bot
Copy link

rspack-bot commented Mar 20, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
nx ✅ success
rspress ✅ success
rsbuild ✅ success
compat ✅ success
examples ✅ success

@ahabhgk ahabhgk requested review from jerrykingxyz and h-a-n-a and removed request for hardfist March 20, 2024 09:10
@ahabhgk ahabhgk enabled auto-merge (squash) March 20, 2024 09:49
@ahabhgk ahabhgk merged commit 217170c into main Mar 20, 2024
27 checks passed
@ahabhgk ahabhgk deleted the refactor-build-module branch March 20, 2024 09:56
@ahabhgk ahabhgk mentioned this pull request Mar 20, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants