Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cached source with raw source #5996

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Mar 21, 2024

Summary

Related: web-infra-dev/rspack-sources#94

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

Copy link

netlify bot commented Mar 21, 2024

👷 Deploy request for rspack pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 2eeb1e5

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Mar 21, 2024
Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for rspack-back canceled.

Name Link
🔨 Latest commit 2eeb1e5
🔍 Latest deploy log https://app.netlify.com/sites/rspack-back/deploys/65fce89f2fd03a0008e33f54

@SyMind
Copy link
Member Author

SyMind commented Mar 21, 2024

!bench

@SyMind SyMind marked this pull request as ready for review March 21, 2024 12:14
@SyMind SyMind requested a review from hardfist as a code owner March 21, 2024 12:14
@rspack-bot
Copy link

rspack-bot commented Mar 21, 2024

📝 Benchmark detail: Open

Name Base (2024-03-21 6b6429d) Current Change
10000_development-mode + exec 1.92 s ± 30 ms 2.01 s ± 55 ms +4.47 %
10000_development-mode_hmr + exec 743 ms ± 12 ms 735 ms ± 8.4 ms -1.15 %
10000_production-mode + exec 2.97 s ± 39 ms 2.96 s ± 48 ms -0.34 %
arco-pro_development-mode + exec 2.5 s ± 33 ms 2.45 s ± 34 ms -2.00 %
arco-pro_development-mode_hmr + exec 508 ms ± 14 ms 508 ms ± 13 ms +0.15 %
arco-pro_development-mode_hmr_intercept-plugin + exec 527 ms ± 4.4 ms 527 ms ± 2.2 ms -0.12 %
arco-pro_development-mode_intercept-plugin + exec 3.33 s ± 44 ms 3.29 s ± 27 ms -1.12 %
arco-pro_production-mode + exec 4.09 s ± 42 ms 4.08 s ± 33 ms -0.21 %
arco-pro_production-mode_intercept-plugin + exec 4.96 s ± 46 ms 4.95 s ± 66 ms -0.13 %
threejs_development-mode_10x + exec 1.88 s ± 13 ms 1.86 s ± 26 ms -1.11 %
threejs_development-mode_10x_hmr + exec 740 ms ± 6.1 ms 726 ms ± 7 ms -1.88 %
threejs_production-mode_10x + exec 5.85 s ± 37 ms 5.65 s ± 29 ms -3.51 %

@SyMind SyMind force-pushed the fix-cached-source-with-raw-source branch from c16afc2 to 3dccebd Compare March 21, 2024 12:17
@jerrykingxyz
Copy link
Collaborator

!bench

@rspack-bot
Copy link

rspack-bot commented Mar 22, 2024

📝 Benchmark detail: Open

Name Base (2024-03-22 67df93d) Current Change
10000_development-mode + exec 1.97 s ± 38 ms 1.95 s ± 46 ms -1.08 %
10000_development-mode_hmr + exec 744 ms ± 3.7 ms 739 ms ± 7.5 ms -0.65 %
10000_production-mode + exec 2.8 s ± 29 ms 2.81 s ± 28 ms +0.64 %
arco-pro_development-mode + exec 2.46 s ± 33 ms 2.46 s ± 34 ms +0.09 %
arco-pro_development-mode_hmr + exec 512 ms ± 14 ms 513 ms ± 2.1 ms +0.14 %
arco-pro_development-mode_hmr_intercept-plugin + exec 530 ms ± 3.3 ms 528 ms ± 5.2 ms -0.33 %
arco-pro_development-mode_intercept-plugin + exec 3.32 s ± 45 ms 3.28 s ± 18 ms -0.96 %
arco-pro_production-mode + exec 4.09 s ± 17 ms 4.14 s ± 86 ms +1.26 %
arco-pro_production-mode_intercept-plugin + exec 4.99 s ± 72 ms 4.97 s ± 95 ms -0.37 %
threejs_development-mode_10x + exec 1.9 s ± 16 ms 1.87 s ± 29 ms -1.71 %
threejs_development-mode_10x_hmr + exec 735 ms ± 5.5 ms 722 ms ± 5.1 ms -1.84 %
threejs_production-mode_10x + exec 5.65 s ± 34 ms 5.66 s ± 25 ms +0.05 %

@SyMind SyMind merged commit 0ebe95d into web-infra-dev:main Mar 22, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants