Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Move @import to top of concatenated CSS output (#6000) #6016

Merged
merged 4 commits into from
Mar 25, 2024
Merged

fix: Move @import to top of concatenated CSS output (#6000) #6016

merged 4 commits into from
Mar 25, 2024

Conversation

woai3c
Copy link
Contributor

@woai3c woai3c commented Mar 24, 2024 •
edited

Summary

fix issue 6000

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@CLAassistant
Copy link

CLAassistant commented Mar 24, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Mar 24, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 24, 2024 •
edited

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 65be1d5
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66012fdb88bb0e0008f72f23

@ahabhgk
Copy link
Collaborator

ahabhgk commented Mar 25, 2024

And need add a test in packages/rspack/tests/configCases, we usually add test at js package, rust snapshot test will be removed in the future

@woai3c
Copy link
Contributor Author

woai3c commented Mar 25, 2024

And need add a test in packages/rspack/tests/configCases, we usually add test at js package, rust snapshot test will be removed in the future

ok

@woai3c woai3c requested a review from hardfist as a code owner March 25, 2024 07:47
ahabhgk
ahabhgk approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ahabhgk ahabhgk enabled auto-merge (squash) March 25, 2024 08:06
@ahabhgk ahabhgk merged commit 5dbba23 into web-infra-dev:main Mar 25, 2024
24 of 36 checks passed
@woai3c woai3c mentioned this pull request Mar 25, 2024
Closed
@ahabhgk ahabhgk linked an issue Mar 25, 2024 that may be closed by this pull request
[Bug]: In concatenated css output, @imports are not moved to the top of the file #6000
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

@hardfist hardfist Awaiting requested review from hardfist

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: In concatenated css output, @imports are not moved to the top of the file
3 participants
@woai3c @CLAassistant @ahabhgk