Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: errors thrown in userland callbacks should not panic #6082

Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix: errors thrown in userland callbacks should not panic #6082

merged 1 commit into from
Apr 26, 2024

Conversation

h-a-n-a
Copy link
Collaborator

@h-a-n-a h-a-n-a commented Apr 1, 2024 •
edited

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Apr 1, 2024
@h-a-n-a Graphite App
Copy link
Collaborator Author

h-a-n-a commented Apr 1, 2024 •
edited

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @h-a-n-a and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 1, 2024
@h-a-n-a h-a-n-a force-pushed the 04-01-fix_errors_thrown_in_userland_callbacks_should_not_panic branch from d8a53f6 to 52bf954 Compare April 1, 2024 11:39
Base automatically changed from fix/error-chunk-name to main April 1, 2024 11:50
@h-a-n-a h-a-n-a force-pushed the 04-01-fix_errors_thrown_in_userland_callbacks_should_not_panic branch from 52bf954 to ad4264e Compare April 1, 2024 11:56
@netlify Netlify
Copy link

netlify bot commented Apr 1, 2024 •
edited

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 0d70d54
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/662b5048dbf2fc00080cfdcd

@h-a-n-a h-a-n-a force-pushed the 04-01-fix_errors_thrown_in_userland_callbacks_should_not_panic branch 4 times, most recently from 52f8030 to b665eed Compare April 25, 2024 11:57
@h-a-n-a h-a-n-a force-pushed the 04-01-fix_errors_thrown_in_userland_callbacks_should_not_panic branch from b665eed to 0d70d54 Compare April 26, 2024 06:57
@h-a-n-a h-a-n-a marked this pull request as ready for review April 26, 2024 07:08
@h-a-n-a h-a-n-a merged commit d968a3b into main Apr 26, 2024
34 checks passed
@h-a-n-a h-a-n-a deleted the 04-01-fix_errors_thrown_in_userland_callbacks_should_not_panic branch April 26, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Assignees

@h-a-n-a h-a-n-a

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@h-a-n-a @LingyuCoder