Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make CopyPlugin.test faster and more stable #6115

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

xc2
Copy link
Collaborator

@xc2 xc2 commented Apr 3, 2024

Summary

related: #6084

failing CI samples:

packages/rspack test: FAIL tests/copyPlugin/CopyPlugin.test.js (66.335 s, 34 MB heap size)
packages/rspack test:   ● CopyPlugin › watch mode › should include all files when multiple patterns used
packages/rspack test:     TypeError: Cannot read properties of undefined (reading 'compilation')
packages/rspack test:        9 | 	const assets = {};
packages/rspack test:       10 |
packages/rspack test:     > 11 | 	Reflect.ownKeys(stats.compilation.assets)
packages/rspack test:          | 	                      ^
packages/rspack test:       12 | 		.filter(a => a !== "main.js")
packages/rspack test:       13 | 		.forEach(asset => {
packages/rspack test:       14 | 			assets[transformWindowPath(asset)] = readAsset(asset, compiler, stats);
packages/rspack test:       at readAssets (tests/copyPlugin/helpers/readAssets.js:11:24)
packages/rspack test:       at tests/copyPlugin/helpers/run.js:191:25
packages/rspack test:       at shutdown (dist/Watching.js:99:21)
packages/rspack test:       at Watching.finalCallback [as _done] (dist/Watching.js:116:13)
packages/rspack test:       at onCompile (dist/Watching.js:2[61](https://github.com/web-infra-dev/rspack/actions/runs/8505294188/job/23293849274#step:9:62):18)
packages/rspack test:       at dist/Compiler.js:424:28
packages/rspack test:       at Hook.eval [as callAsync] (eval at create (../../node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1)
packages/rspack test:       at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (../../node_modules/tapable/lib/Hook.js:18:14)
packages/rspack test:       at dist/Compiler.js:420:41
packages/rspack test:       at dist/Compiler.js:747:[65](https://github.com/web-infra-dev/rspack/actions/runs/8505294188/job/23293849274#step:9:66)

Checklist

  • Tests updated (or not required). - no need
  • Documentation updated (or not required). - no need

Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit d6506e1
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/660d71ace7178000085729da

@xc2 xc2 marked this pull request as ready for review April 3, 2024 15:30
@xc2 xc2 mentioned this pull request Apr 3, 2024
2 tasks
@xc2 xc2 requested a review from hardfist April 3, 2024 16:46
@LingyuCoder
Copy link
Collaborator

LGTM, Thanks

@LingyuCoder LingyuCoder merged commit 518c68a into web-infra-dev:main Apr 7, 2024
34 checks passed
@xc2 xc2 deleted the ci/fix-failure-2 branch April 7, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants