-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: module group get_key #6142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: performance
release: performance related release(mr only)
label
Apr 9, 2024
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
!bench |
📝 Benchmark detail: Open
|
SyMind
force-pushed
the
perf-module-group
branch
from
April 9, 2024 03:41
5880fd3
to
99f2232
Compare
JSerFeng
approved these changes
Apr 9, 2024
!canary |
0.5.9-canary-677c131-20240409051353 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace
num_bigint::BigUint
withFxHasher
to avoid the overhead of hash large key inchunk_key_to_string
.It will be very evident in the HMR stage, where
ChunkUkey
continues to increase andBigUint
values will continue to increase.The hexadecimal string representation of
BigUint
can become excessively long.Making its hashing computationally expensive.
Checklist