Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix css-extract-rspack-plugin typos #6184

Merged
merged 2 commits into from
Apr 10, 2024
Merged

docs: fix css-extract-rspack-plugin typos #6184

merged 2 commits into from
Apr 10, 2024

Conversation

edbzn
Copy link
Contributor

@edbzn edbzn commented Apr 10, 2024

Summary

Fix typo in new css-extract-rspack-plugin en doc.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@edbzn edbzn requested a review from hardfist as a code owner April 10, 2024 11:01
@CLAassistant
Copy link

CLAassistant commented Apr 10, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@netlify Netlify
Copy link

netlify bot commented Apr 10, 2024 •
edited

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 913a143
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/661675b742c2fa000817f275
😎 Deploy Preview https://deploy-preview-6184--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ahabhgk ahabhgk enabled auto-merge (squash) April 10, 2024 11:20
@xc2
Copy link
Collaborator

xc2 commented Apr 10, 2024

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.✅ ahabhgk❌ edbznYou have signed the CLA already but the status is still pending? Let us recheck it.

@edbzn could you please sign the CLA

@edbzn
Copy link
Contributor Author

edbzn commented Apr 10, 2024

Done :)

@JSerFeng JSerFeng mentioned this pull request Apr 10, 2024
Closed
2 tasks
@xc2 xc2 requested review from xc2 and removed request for xc2 April 10, 2024 13:37
@chenjiahan chenjiahan merged commit 900a3f6 into web-infra-dev:main Apr 10, 2024
5 checks passed
@chenjiahan
Copy link
Member

Thanks ❤️

@edbzn edbzn deleted the patch-1 branch April 10, 2024 13:53
@renovate renovate bot mentioned this pull request May 7, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xc2 xc2 xc2 requested changes

@ahabhgk ahabhgk ahabhgk approved these changes

@hardfist hardfist Awaiting requested review from hardfist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@edbzn @CLAassistant @xc2 @chenjiahan @ahabhgk