Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rest compilation hooks #6196

Merged
merged 4 commits into from
Apr 11, 2024
Merged

refactor: rest compilation hooks #6196

merged 4 commits into from
Apr 11, 2024

Conversation

ahabhgk
Copy link
Collaborator

@ahabhgk ahabhgk commented Apr 11, 2024

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@ahabhgk ahabhgk requested a review from hardfist as a code owner April 11, 2024 03:37
@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Apr 11, 2024

!bench

@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Apr 11, 2024

!eco-ci

Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 977e85b
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66178227456f980008bd4c69

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 11, 2024
@rspack-bot
Copy link

rspack-bot commented Apr 11, 2024

📝 Benchmark detail: Open

Name Base (2024-04-11 900a3f6) Current Change
10000_development-mode + exec 2.69 s ± 37 ms 2.69 s ± 48 ms -0.21 %
10000_development-mode_hmr + exec 688 ms ± 8.2 ms 689 ms ± 6.2 ms +0.12 %
10000_production-mode + exec 2.51 s ± 45 ms 2.52 s ± 24 ms +0.09 %
arco-pro_development-mode + exec 2.5 s ± 104 ms 2.48 s ± 98 ms -0.91 %
arco-pro_development-mode_hmr + exec 431 ms ± 3.3 ms 432 ms ± 1.5 ms +0.07 %
arco-pro_development-mode_hmr_intercept-plugin + exec 443 ms ± 3.5 ms 442 ms ± 2 ms -0.19 %
arco-pro_development-mode_intercept-plugin + exec 3.28 s ± 105 ms 3.29 s ± 77 ms +0.22 %
arco-pro_production-mode + exec 3.96 s ± 101 ms 4.03 s ± 87 ms +1.67 %
arco-pro_production-mode_intercept-plugin + exec 4.81 s ± 123 ms 4.77 s ± 84 ms -0.79 %
threejs_development-mode_10x + exec 2.06 s ± 18 ms 2.05 s ± 20 ms -0.33 %
threejs_development-mode_10x_hmr + exec 747 ms ± 8 ms 749 ms ± 7.6 ms +0.23 %
threejs_production-mode_10x + exec 5.15 s ± 40 ms 5.18 s ± 35 ms +0.65 %

@rspack-bot
Copy link

rspack-bot commented Apr 11, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
nx ✅ success
rspress ✅ success
rsbuild ✅ success
compat ✅ success
examples ✅ success

@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Apr 11, 2024

!bench

@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Apr 11, 2024

!eco-ci

@rspack-bot
Copy link

rspack-bot commented Apr 11, 2024

📝 Benchmark detail: Open

Name Base (2024-04-11 900a3f6) Current Change
10000_development-mode + exec 2.69 s ± 37 ms 2.68 s ± 24 ms -0.59 %
10000_development-mode_hmr + exec 688 ms ± 8.2 ms 692 ms ± 5.2 ms +0.66 %
10000_production-mode + exec 2.51 s ± 45 ms 2.54 s ± 27 ms +0.91 %
arco-pro_development-mode + exec 2.5 s ± 104 ms 2.52 s ± 127 ms +0.92 %
arco-pro_development-mode_hmr + exec 431 ms ± 3.3 ms 432 ms ± 3.5 ms +0.05 %
arco-pro_development-mode_hmr_intercept-plugin + exec 443 ms ± 3.5 ms 443 ms ± 4.2 ms -0.02 %
arco-pro_development-mode_intercept-plugin + exec 3.28 s ± 105 ms 3.29 s ± 88 ms +0.40 %
arco-pro_production-mode + exec 3.96 s ± 101 ms 4.03 s ± 124 ms +1.85 %
arco-pro_production-mode_intercept-plugin + exec 4.81 s ± 123 ms 4.8 s ± 100 ms -0.09 %
threejs_development-mode_10x + exec 2.06 s ± 18 ms 2.06 s ± 21 ms -0.15 %
threejs_development-mode_10x_hmr + exec 747 ms ± 8 ms 756 ms ± 15 ms +1.18 %
threejs_production-mode_10x + exec 5.15 s ± 40 ms 5.2 s ± 40 ms +0.88 %

@rspack-bot
Copy link

rspack-bot commented Apr 11, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
nx ✅ success
rspress ✅ success
rsbuild ✅ success
compat ✅ success
examples ✅ success

@ahabhgk ahabhgk enabled auto-merge (squash) April 11, 2024 06:46
@ahabhgk ahabhgk merged commit 97b17f0 into main Apr 11, 2024
28 checks passed
@ahabhgk ahabhgk deleted the refactor-rest-hook branch April 11, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants