Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: favicon path of HtmlRspackPlugin #6200

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix: favicon path of HtmlRspackPlugin #6200

merged 1 commit into from
Apr 11, 2024

Conversation

LingyuCoder
Copy link
Collaborator

Summary

Fix #6063

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Apr 11, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 11, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 11, 2024 •
edited

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 6494c19
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66178e67ac9270000897fb49

@LingyuCoder LingyuCoder enabled auto-merge (squash) April 11, 2024 07:39
@LingyuCoder LingyuCoder merged commit e3cf809 into main Apr 11, 2024
32 checks passed
@LingyuCoder LingyuCoder deleted the fix/html-favicon-path branch April 11, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

@LingyuCoder LingyuCoder

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: rspack.HtmlRspackPlugin favicon behavior inconsistent with html-webpack-plugin
2 participants
@LingyuCoder @ahabhgk