Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use set as queue for flag_dependency_usage_plugin #6203

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

JSerFeng
Copy link
Collaborator

Summary

Webpack uses SetQueue under the hood, thus can reduce many duplication computations

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: performance release: performance related release(mr only) label Apr 11, 2024
Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 721a02b
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/661799143c2588000797ef33
😎 Deploy Preview https://deploy-preview-6203--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 11, 2024
@JSerFeng
Copy link
Collaborator Author

!bench

@rspack-bot
Copy link

rspack-bot commented Apr 11, 2024

📝 Benchmark detail: Open

Name Base (2024-04-11 900a3f6) Current Change
10000_development-mode + exec 2.69 s ± 37 ms 2.69 s ± 38 ms +0.05 %
10000_development-mode_hmr + exec 688 ms ± 8.2 ms 690 ms ± 6.4 ms +0.25 %
10000_production-mode + exec 2.51 s ± 45 ms 2.54 s ± 22 ms +1.07 %
arco-pro_development-mode + exec 2.5 s ± 104 ms 2.55 s ± 71 ms +1.88 %
arco-pro_development-mode_hmr + exec 431 ms ± 3.3 ms 433 ms ± 2.1 ms +0.36 %
arco-pro_development-mode_hmr_intercept-plugin + exec 443 ms ± 3.5 ms 444 ms ± 3.8 ms +0.14 %
arco-pro_development-mode_intercept-plugin + exec 3.28 s ± 105 ms 3.29 s ± 73 ms +0.50 %
arco-pro_production-mode + exec 3.96 s ± 101 ms 4 s ± 89 ms +1.03 %
arco-pro_production-mode_intercept-plugin + exec 4.81 s ± 123 ms 4.81 s ± 85 ms 0.00 %
threejs_development-mode_10x + exec 2.06 s ± 18 ms 2.06 s ± 19 ms +0.01 %
threejs_development-mode_10x_hmr + exec 747 ms ± 8 ms 759 ms ± 22 ms +1.50 %
threejs_production-mode_10x + exec 5.15 s ± 40 ms 5.17 s ± 39 ms +0.28 %

@JSerFeng JSerFeng merged commit 18a47c4 into main Apr 11, 2024
32 checks passed
@JSerFeng JSerFeng deleted the perf/flag-usage branch April 11, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants