Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce api-extractor #6208

Merged
merged 1 commit into from
Apr 16, 2024
Merged

chore: introduce api-extractor #6208

merged 1 commit into from
Apr 16, 2024

Conversation

h-a-n-a
Copy link
Collaborator

@h-a-n-a h-a-n-a commented Apr 11, 2024

Summary

Note: force build npm packages with pnpm build:js and pnpm api-extractor:local locally to generate API change if api-extractor check failed.
Command: pnpm build:js && pnpm api-extractor:local

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 57a7296
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/661d1b8c1478b00008957eb5

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 11, 2024
@h-a-n-a h-a-n-a force-pushed the chore/api-extractor branch 5 times, most recently from 25689d8 to 1b3eb19 Compare April 15, 2024 10:13
@h-a-n-a
Copy link
Collaborator Author

h-a-n-a commented Apr 15, 2024

blocked by microsoft/rushstack#4646

@h-a-n-a
Copy link
Collaborator Author

h-a-n-a commented Apr 15, 2024

Seems it's correct if its being rebuild in force mode. Let's get it merge and check if microsoft/TypeScript#17944 (comment) is true.

@h-a-n-a h-a-n-a marked this pull request as ready for review April 16, 2024 06:09
@h-a-n-a h-a-n-a merged commit 9e43100 into main Apr 16, 2024
31 checks passed
@h-a-n-a h-a-n-a deleted the chore/api-extractor branch April 16, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants