Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split task in make stage #6258

Merged
merged 3 commits into from
Apr 18, 2024
Merged

refactor: split task in make stage #6258

merged 3 commits into from
Apr 18, 2024

Conversation

jerrykingxyz
Copy link
Collaborator

@jerrykingxyz jerrykingxyz commented Apr 16, 2024 •
edited

Summary

  • Define task specification in rspack_core/src/utils/task_loop
  • Core task scheduling logic in rspack_core/src/utils/task_loop
  • split task in make stage

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Apr 16, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 16, 2024 •
edited

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit ca8aeed
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6620ba5823bc590008e66573
😎 Deploy Preview https://deploy-preview-6258--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 16, 2024
@Boshen Boshen marked this pull request as draft April 16, 2024 13:19
@jerrykingxyz jerrykingxyz changed the title feat: define common task loop refactor: split task in make stage Apr 18, 2024
@github-actions github-actions bot removed the release: feature release: feature related release(mr only) label Apr 18, 2024
@jerrykingxyz jerrykingxyz marked this pull request as ready for review April 18, 2024 07:08
@jerrykingxyz jerrykingxyz mentioned this pull request Apr 18, 2024
Open
@Boshen Boshen merged commit c3c83ed into main Apr 18, 2024
34 checks passed
@Boshen Boshen deleted the jerry/task_loop branch April 18, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen approved these changes

Assignees

@jerrykingxyz jerrykingxyz

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jerrykingxyz @Boshen