Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stable hot step test #6267

Merged
merged 4 commits into from
Apr 17, 2024
Merged

chore: stable hot step test #6267

merged 4 commits into from
Apr 17, 2024

Conversation

LingyuCoder
Copy link
Collaborator

@LingyuCoder LingyuCoder commented Apr 17, 2024

Summary

  • Remove bundle size check
  • Sort manifest items
  • Fix workflow result status

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@LingyuCoder
Copy link
Collaborator Author

!test-ng

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 17, 2024
Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 16e31df
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/661f9b198d22a40008793fac

Copy link
Contributor

🔴🔴🔴 Test new runner failed

Task: https://github.com/web-infra-dev/rspack/actions/runs/8719333075


> monorepo@0.6.2 test:ng /home/webinfra/ec2-linux-ci-0/_work/rspack/rspack
> pnpm --filter "@rspack/test-tools" test:ng "--no-colors" "--silent=true"

npm/darwin-arm64                         |  WARN  Unsupported platform: wanted: {"cpu":["arm64"],"os":["darwin"],"libc":["any"]} (current: {"os":"linux","cpu":"x64","libc":"glibc"})
npm/darwin-x64                           |  WARN  Unsupported platform: wanted: {"cpu":["x64"],"os":["darwin"],"libc":["any"]} (current: {"os":"linux","cpu":"x64","libc":"glibc"})
npm/win32-x64-msvc                       |  WARN  Unsupported platform: wanted: {"cpu":["x64"],"os":["win32"],"libc":["any"]} (current: {"os":"linux","cpu":"x64","libc":"glibc"})

> @rspack/test-tools@0.6.2 test:ng /home/webinfra/ec2-linux-ci-0/_work/rspack/rspack/packages/rspack-test-tools
> cross-env SNAPSHOT=legacy NO_COLOR=1 node --expose-gc --max-old-space-size=8192 --experimental-vm-modules ../../node_modules/jest-cli/bin/jest --logHeapUsage --config ./jest.config.legacy.js "--no-colors" "--silent=true"

jest-haste-map: Haste module naming collision: example-basic
  The following files share their name; please adjust your hasteImpl:
    * <rootDir>/tests/treeShakingCases/cjs-tree-shaking-basic/package.json
    * <rootDir>/tests/treeShakingCases/reexport-all-as/package.json

PASS tests/HashTestCases.test.js (49 MB heap size)
PASS tests/Diagnostics.test.js (50 MB heap size)
PASS tests/StatsTestCases.basictest.js (74 MB heap size)
PASS tests/WatchTestCases.longtest.js (5.324 s, 48 MB heap size)
PASS tests/TestCasesNormal.basictest.js (11.303 s, 77 MB heap size)
PASS tests/HotTestCasesWebWorker.test.js (16.265 s, 68 MB heap size)
PASS tests/HotTestCasesNode.test.js (16.37 s, 67 MB heap size)
PASS tests/HotTestCasesWeb.test.js (16.445 s, 69 MB heap size)
FAIL tests/HotTestStepWeb.test.js (16.607 s, 72 MB heap size)
  ● HotStepTestCasesNode › worker › issue-5597 › exported tests › should support hot module replacement in WebWorkers

    expect(received).toBe(expected) // Object.is equality

    - Expected  - 4
    + Received  + 4

    @@ -19,22 +19,22 @@
      - Update: workerA_js.LAST_HASH.hot-update.js, size: 432
      - Update: workerB_js.LAST_HASH.hot-update.js, size: 432

      ## Manifest

    - ### [runtime of workerA_js].LAST_HASH.hot-update.json
    + ### [runtime of workerB_js].LAST_HASH.hot-update.json

      ```json
    - {"c":["shared","workerA_js"],"r":["main","workerB_js"],"m":[]}
    + {"c":["shared","workerB_js"],"r":["main","workerA_js"],"m":[]}
      ```



    - ### [runtime of workerB_js].LAST_HASH.hot-update.json
    + ### [runtime of workerA_js].LAST_HASH.hot-update.json

      ```json
    - {"c":["shared","workerB_js"],"r":["main","workerA_js"],"m":[]}
    + {"c":["shared","workerA_js"],"r":["main","workerB_js"],"m":[]}
      ```



      ### main.LAST_HASH.hot-update.json

      212 |             .replace(/\r\n/g, "\n")
      213 |             .trim();
    > 214 |         expect(content).toBe(snapshotContent);
          |                         ^
      215 |     }
      216 | }
      217 | exports.RspackHotStepProcessor = RspackHotStepProcessor;

      at RspackHotStepProcessor.matchStepSnapshot (dist/processor/hot-step.js:214:25)
      at dist/processor/hot-step.js:49:18
      at dist/runner/hot-step.js:28:21

(node:2439815) ExperimentalWarning: VM Modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
PASS tests/ConfigTestCases.basictest.js (60.828 s, 399 MB heap size)
A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks. Active timers can also cause this, ensure that .unref() was called on them.

Test Suites: 1 failed, 9 passed, 10 total
Tests:       1 failed, 5 skipped, 2553 passed, 2559 total
Snapshots:   58 passed, 58 total
Time:        62.068 s
/home/webinfra/ec2-linux-ci-0/_work/rspack/rspack/packages/rspack-test-tools:
 ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @rspack/test-tools@0.6.2 test:ng: `cross-env SNAPSHOT=legacy NO_COLOR=1 node --expose-gc --max-old-space-size=8192 --experimental-vm-modules ../../node_modules/jest-cli/bin/jest --logHeapUsage --config ./jest.config.legacy.js "--no-colors" "--silent=true"`
Exit status 1
 ELIFECYCLE  Command failed with exit code 1.

@LingyuCoder
Copy link
Collaborator Author

!test-ng

Copy link
Contributor

🔴🔴🔴 Test new runner failed

Task: https://github.com/web-infra-dev/rspack/actions/runs/8719523337


> monorepo@0.6.2 test:ng /home/webinfra/ec2-linux-ci-0/_work/rspack/rspack
> pnpm --filter "@rspack/test-tools" test:ng "--no-colors" "--silent=true"

npm/darwin-arm64                         |  WARN  Unsupported platform: wanted: {"cpu":["arm64"],"os":["darwin"],"libc":["any"]} (current: {"os":"linux","cpu":"x64","libc":"glibc"})
npm/darwin-x64                           |  WARN  Unsupported platform: wanted: {"cpu":["x64"],"os":["darwin"],"libc":["any"]} (current: {"os":"linux","cpu":"x64","libc":"glibc"})
npm/win32-x64-msvc                       |  WARN  Unsupported platform: wanted: {"cpu":["x64"],"os":["win32"],"libc":["any"]} (current: {"os":"linux","cpu":"x64","libc":"glibc"})

> @rspack/test-tools@0.6.2 test:ng /home/webinfra/ec2-linux-ci-0/_work/rspack/rspack/packages/rspack-test-tools
> cross-env SNAPSHOT=legacy NO_COLOR=1 node --expose-gc --max-old-space-size=8192 --experimental-vm-modules ../../node_modules/jest-cli/bin/jest --logHeapUsage --config ./jest.config.legacy.js "--no-colors" "--silent=true"

jest-haste-map: Haste module naming collision: example-basic
  The following files share their name; please adjust your hasteImpl:
    * <rootDir>/tests/treeShakingCases/cjs-tree-shaking-basic/package.json
    * <rootDir>/tests/treeShakingCases/reexport-all-as/package.json

PASS tests/Diagnostics.test.js (50 MB heap size)
PASS tests/HashTestCases.test.js (49 MB heap size)
PASS tests/StatsTestCases.basictest.js (74 MB heap size)
PASS tests/WatchTestCases.longtest.js (48 MB heap size)
PASS tests/TestCasesNormal.basictest.js (7.578 s, 77 MB heap size)
PASS tests/HotTestCasesWebWorker.test.js (10.532 s, 68 MB heap size)
PASS tests/HotTestCasesWeb.test.js (10.637 s, 69 MB heap size)
PASS tests/HotTestCasesNode.test.js (10.785 s, 67 MB heap size)
PASS tests/HotTestStepWeb.test.js (11.126 s, 72 MB heap size)
(node:2444526) ExperimentalWarning: VM Modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
PASS tests/ConfigTestCases.basictest.js (56.521 s, 397 MB heap size)
A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks. Active timers can also cause this, ensure that .unref() was called on them.

Test Suites: 10 passed, 10 total
Tests:       5 skipped, 2554 passed, 2559 total
Snapshots:   58 passed, 58 total
Time:        57.608 s

Copy link
Contributor

🟢🟢🟢 Test new runner successed

Task: https://github.com/web-infra-dev/rspack/actions/runs/8719839670


> monorepo@0.6.2 test:ng /home/webinfra/ec2-linux-ci-0/_work/rspack/rspack
> pnpm --filter "@rspack/test-tools" test:ng "--no-colors" "--silent=true" "--force-exit"

npm/darwin-arm64                         |  WARN  Unsupported platform: wanted: {"cpu":["arm64"],"os":["darwin"],"libc":["any"]} (current: {"os":"linux","cpu":"x64","libc":"glibc"})
npm/darwin-x64                           |  WARN  Unsupported platform: wanted: {"cpu":["x64"],"os":["darwin"],"libc":["any"]} (current: {"os":"linux","cpu":"x64","libc":"glibc"})
npm/win32-x64-msvc                       |  WARN  Unsupported platform: wanted: {"cpu":["x64"],"os":["win32"],"libc":["any"]} (current: {"os":"linux","cpu":"x64","libc":"glibc"})

> @rspack/test-tools@0.6.2 test:ng /home/webinfra/ec2-linux-ci-0/_work/rspack/rspack/packages/rspack-test-tools
> cross-env SNAPSHOT=legacy NO_COLOR=1 node --expose-gc --max-old-space-size=8192 --experimental-vm-modules ../../node_modules/jest-cli/bin/jest --logHeapUsage --config ./jest.config.legacy.js "--no-colors" "--silent=true" "--force-exit"

jest-haste-map: Haste module naming collision: example-basic
  The following files share their name; please adjust your hasteImpl:
    * <rootDir>/tests/treeShakingCases/cjs-tree-shaking-basic/package.json
    * <rootDir>/tests/treeShakingCases/reexport-all-as/package.json

PASS tests/Diagnostics.test.js (50 MB heap size)
PASS tests/HashTestCases.test.js (49 MB heap size)
PASS tests/StatsTestCases.basictest.js (74 MB heap size)
PASS tests/WatchTestCases.longtest.js (48 MB heap size)
PASS tests/TestCasesNormal.basictest.js (6.319 s, 77 MB heap size)
PASS tests/HotTestCasesWebWorker.test.js (9.469 s, 68 MB heap size)
PASS tests/HotTestCasesWeb.test.js (9.787 s, 69 MB heap size)
PASS tests/HotTestCasesNode.test.js (9.941 s, 67 MB heap size)
PASS tests/HotTestStepWeb.test.js (10.596 s, 72 MB heap size)
(node:2460738) ExperimentalWarning: VM Modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
PASS tests/ConfigTestCases.basictest.js (68.073 s, 401 MB heap size)
A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks. Active timers can also cause this, ensure that .unref() was called on them.

Test Suites: 10 passed, 10 total
Tests:       5 skipped, 2554 passed, 2559 total
Snapshots:   58 passed, 58 total
Time:        69.305 s
Force exiting Jest: Have you considered using `--detectOpenHandles` to detect async operations that kept running after all tests finished?
Test new runner successed

@LingyuCoder LingyuCoder enabled auto-merge (squash) April 17, 2024 10:13
@LingyuCoder LingyuCoder merged commit 632c34f into main Apr 17, 2024
41 checks passed
@LingyuCoder LingyuCoder deleted the chore/stable-manifest-json branch April 17, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants