Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: performance degradation for auxiliary files #6278

Merged

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Apr 18, 2024

Summary

Fix performance degradation cased by #6125 .

image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Apr 18, 2024
Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 61a61ec
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6620c7fb4774fa000892b1fe

@SyMind SyMind changed the title fix: performance issues for auxiliary files fix: performance degradation for auxiliary files Apr 18, 2024
@web-infra-dev web-infra-dev deleted a comment from rspack-bot Apr 18, 2024
@SyMind SyMind force-pushed the perf-auxiliary-files-in-devtool-plugin branch from 09978f4 to d109a48 Compare April 18, 2024 06:25
@SyMind
Copy link
Member Author

SyMind commented Apr 18, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Apr 18, 2024

📝 Benchmark detail: Open

Name Base (2024-04-18 0a88b52) Current Change
10000_development-mode + exec 2.69 s ± 28 ms 2.68 s ± 35 ms -0.47 %
10000_development-mode_hmr + exec 699 ms ± 7.2 ms 688 ms ± 6.7 ms -1.59 %
10000_production-mode + exec 2.57 s ± 16 ms 2.52 s ± 36 ms -2.00 %
arco-pro_development-mode + exec 2.51 s ± 78 ms 2.51 s ± 58 ms 0.00 %
arco-pro_development-mode_hmr + exec 430 ms ± 2 ms 431 ms ± 3.3 ms +0.21 %
arco-pro_development-mode_hmr_intercept-plugin + exec 441 ms ± 1.9 ms 442 ms ± 3.9 ms +0.30 %
arco-pro_development-mode_intercept-plugin + exec 3.3 s ± 63 ms 3.27 s ± 60 ms -0.75 %
arco-pro_production-mode + exec 4.04 s ± 88 ms 4.03 s ± 84 ms -0.32 %
arco-pro_production-mode_intercept-plugin + exec 4.84 s ± 84 ms 4.78 s ± 82 ms -1.08 %
threejs_development-mode_10x + exec 2.06 s ± 21 ms 2.05 s ± 24 ms -0.54 %
threejs_development-mode_10x_hmr + exec 749 ms ± 5.4 ms 751 ms ± 5 ms +0.20 %
threejs_production-mode_10x + exec 5.25 s ± 62 ms 5.17 s ± 26 ms -1.41 %

@web-infra-dev web-infra-dev deleted a comment from rspack-bot Apr 18, 2024
@SyMind SyMind marked this pull request as ready for review April 18, 2024 07:16
@SyMind SyMind merged commit 9b79e85 into web-infra-dev:main Apr 18, 2024
32 checks passed
@SyMind SyMind deleted the perf-auxiliary-files-in-devtool-plugin branch April 18, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants