Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split cutout and repair step in make #6364

Merged
merged 1 commit into from
Apr 25, 2024
Merged

refactor: split cutout and repair step in make #6364

merged 1 commit into from
Apr 25, 2024

Conversation

jerrykingxyz
Copy link
Collaborator

@jerrykingxyz jerrykingxyz commented Apr 25, 2024 •
edited

Summary

  • Split cutout step into make/cutout/*
  • move tasks directory to repair and move repair method to repair/mod.rs
  • create MakeArtifact struct and use it in compilation

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Apr 25, 2024 •
edited

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 6430858
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/662a04860deaf9000887730e

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 25, 2024
@jerrykingxyz jerrykingxyz merged commit 5b8dd1d into main Apr 25, 2024
36 checks passed
@jerrykingxyz jerrykingxyz deleted the jerry/make branch April 25, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Assignees

@jerrykingxyz jerrykingxyz

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jerrykingxyz @h-a-n-a