Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve diagnostics if expressions passed into DefinePlugin are failed to parse #6382

Merged
merged 3 commits into from
May 15, 2024
Merged

feat: improve diagnostics if expressions passed into DefinePlugin are failed to parse #6382

merged 3 commits into from
May 15, 2024

Conversation

shulaoda
Copy link
Contributor

@shulaoda shulaoda commented Apr 27, 2024 •
edited

Summary

#6242

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Apr 27, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the release: performance release: performance related release(mr only) label Apr 27, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 27, 2024 •
edited

✅ Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 87ef20f
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/663a48f7469aff00084f9dd6
😎 Deploy Preview https://deploy-preview-6382--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shulaoda shulaoda force-pushed the perf/improve-builtins-define branch 2 times, most recently from dece3f5 to 679430c Compare April 28, 2024 06:19
@h-a-n-a h-a-n-a changed the title perf: improve diagnostics if builtins.define is failed to parse feat: improve diagnostics if builtins.define is failed to parse Apr 28, 2024
@github-actions github-actions bot added release: feature release: feature related release(mr only) and removed release: performance release: performance related release(mr only) labels Apr 28, 2024
@h-a-n-a h-a-n-a changed the title feat: improve diagnostics if builtins.define is failed to parse feat: improve diagnostics if expressions passed into DefinePlugin is failed to parse Apr 28, 2024
@h-a-n-a h-a-n-a changed the title feat: improve diagnostics if expressions passed into DefinePlugin is failed to parse feat: improve diagnostics if expressions passed into DefinePlugin are failed to parse Apr 28, 2024
@shulaoda shulaoda closed this Apr 28, 2024
@shulaoda shulaoda force-pushed the perf/improve-builtins-define branch from 679430c to e4fdc75 Compare April 28, 2024 09:55
@shulaoda shulaoda reopened this Apr 28, 2024
@shulaoda shulaoda force-pushed the perf/improve-builtins-define branch from 24c6c5c to c01c198 Compare April 28, 2024 09:56
@shulaoda shulaoda requested a review from h-a-n-a April 28, 2024 09:56
@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Apr 29, 2024

Would you add some snapshots to rspack-test-tools/tests/diagnostics/module-parse-failed?

@shulaoda
Copy link
Contributor Author

Would you add some snapshots to rspack-test-tools/tests/diagnostics/module-parse-failed?

done it

@shulaoda shulaoda force-pushed the perf/improve-builtins-define branch from af34fee to 398e84b Compare April 30, 2024 08:25
@shulaoda shulaoda force-pushed the perf/improve-builtins-define branch 2 times, most recently from 379b556 to 0bdf0af Compare May 6, 2024 07:56
@shulaoda shulaoda requested a review from h-a-n-a May 6, 2024 08:15
@shulaoda shulaoda force-pushed the perf/improve-builtins-define branch 2 times, most recently from b387aa7 to 3e7947f Compare May 7, 2024 07:21
@shulaoda shulaoda force-pushed the perf/improve-builtins-define branch from 3e7947f to 87ef20f Compare May 7, 2024 15:29
@h-a-n-a h-a-n-a merged commit 2c08728 into web-infra-dev:main May 15, 2024
29 checks passed
@h-a-n-a
Copy link
Collaborator

h-a-n-a commented May 15, 2024

Thank you!

@shulaoda shulaoda deleted the perf/improve-builtins-define branch May 15, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Assignees
No one assigned
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shulaoda @CLAassistant @h-a-n-a