Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove outdated TODOs in runtime code #6409

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Conversation

chenjiahan
Copy link
Member

Summary

Remove the TODOs in the runtime code, because:

  • The TODO was originally added in 2022, and the current runtime code seems to be the same as webpack, so the TODO should be unnecessary now.
  • The runtime code will be bundled with the user code, when users see the TODOs, it does not feel good.

Links:

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Apr 29, 2024
Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit d65272d
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66305cd140cee60008b7c990
😎 Deploy Preview https://deploy-preview-6409--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 29, 2024
LingyuCoder
LingyuCoder previously approved these changes Apr 29, 2024
@chenjiahan
Copy link
Member Author

I will fix the snapshot tomorrow..

@chenjiahan chenjiahan enabled auto-merge (squash) April 30, 2024 07:09
@chenjiahan chenjiahan merged commit ea79a64 into main Apr 30, 2024
31 checks passed
@chenjiahan chenjiahan deleted the runtime_todo_0429 branch April 30, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants