Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(minimizer): resolve error in minimizing esm asset file #6521

Merged
merged 3 commits into from
May 14, 2024
Merged

fix(minimizer): resolve error in minimizing esm asset file #6521

merged 3 commits into from
May 14, 2024

Conversation

xc2
Copy link
Collaborator

@xc2 xc2 commented May 13, 2024 •
edited
Loading

Summary

let swc minimizer determine the module type if it is unknown - align with webpack and terser-webpack-plugin.

Fixes: #6513

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required) - No need.

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label May 13, 2024
@netlify Netlify
Copy link

netlify bot commented May 13, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 4f32e7c
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/664242c138646800078c88fc

@xc2 xc2 requested a review from h-a-n-a May 13, 2024 16:40
@xc2 xc2 changed the title fix(minimizer): let swc minimizer determine the module type if unknown fix(minimizer): let swc minimizer determine the module type if it is unknown May 13, 2024
@xc2 xc2 changed the title fix(minimizer): let swc minimizer determine the module type if it is unknown fix(minimizer): resolve error in minimizing esm asset file May 13, 2024
h-a-n-a
h-a-n-a approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@h-a-n-a h-a-n-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@h-a-n-a h-a-n-a merged commit 06e98c9 into web-infra-dev:main May 14, 2024
35 checks passed
@xc2 xc2 deleted the fix/minimize-module branch May 14, 2024 04:18
@renovate renovate bot mentioned this pull request Jun 12, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Milestone
No milestone
2 participants
@xc2 @h-a-n-a