Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: put visited_chunk_group_keys out of the loop and use FxHashMap #6769

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Jun 11, 2024

Internal project performance improvement.

Before:

LOG from rspack.EnsureChunkConditionsPlugin
<t> ensure chunk conditions: 11436 ms

After:

LOG from rspack.EnsureChunkConditionsPlugin
<t> ensure chunk conditions: 3463 ms

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 6466809
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6667f7c107a991000845c379

@github-actions github-actions bot added the release: performance release: performance related release(mr only) label Jun 11, 2024
@SyMind
Copy link
Member Author

SyMind commented Jun 11, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Jun 11, 2024

📝 Benchmark detail: Open

Name Base (2024-06-11 34bb9ea) Current Change
10000_development-mode + exec 2.24 s ± 26 ms 2.24 s ± 21 ms +0.16 %
10000_development-mode_hmr + exec 737 ms ± 14 ms 739 ms ± 17 ms +0.32 %
10000_production-mode + exec 2.58 s ± 21 ms 2.58 s ± 24 ms -0.10 %
arco-pro_development-mode + exec 1.92 s ± 78 ms 1.95 s ± 89 ms +1.29 %
arco-pro_development-mode_hmr + exec 441 ms ± 1.3 ms 442 ms ± 1.8 ms +0.32 %
arco-pro_production-mode + exec 3.51 s ± 71 ms 3.53 s ± 87 ms +0.73 %
threejs_development-mode_10x + exec 1.41 s ± 15 ms 1.4 s ± 19 ms -0.35 %
threejs_development-mode_10x_hmr + exec 802 ms ± 6.9 ms 808 ms ± 9.4 ms +0.67 %
threejs_production-mode_10x + exec 4.71 s ± 20 ms 4.72 s ± 27 ms +0.32 %

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit ec659a1
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/666806dbaa7e0800082bffe1

@SyMind SyMind force-pushed the perf-ensure-conditions-plugin branch from d17299d to 260df8b Compare June 11, 2024 07:09
JSerFeng
JSerFeng previously approved these changes Jun 11, 2024
@SyMind SyMind changed the title perf: put visited_chunk_group_keys out of the loop and use FxHashMap … perf: put visited_chunk_group_keys out of the loop and use FxHashMap Jun 11, 2024
@JSerFeng JSerFeng dismissed their stale review June 11, 2024 07:40

approve by mistake

@SyMind SyMind force-pushed the perf-ensure-conditions-plugin branch from 260df8b to ec659a1 Compare June 11, 2024 08:12
@JSerFeng JSerFeng enabled auto-merge (squash) June 11, 2024 08:15
@JSerFeng JSerFeng merged commit db6c8be into web-infra-dev:main Jun 11, 2024
29 checks passed
@SyMind SyMind deleted the perf-ensure-conditions-plugin branch June 11, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants