Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: context passed into the ModuleFactory is not correct #6946

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix: context passed into the ModuleFactory is not correct #6946

merged 1 commit into from
Jun 27, 2024
+6 −3

Conversation

h-a-n-a
Copy link
Collaborator

@h-a-n-a h-a-n-a commented Jun 27, 2024 •
edited
Loading

Summary

Partially fixed the compile issue of #5554

This is still not be able to turn on:

  ● ConfigTestCases › inner-graph › basic › exported tests › myFunction should have the correct exports used for ./assert

    expect(received).toEqual(expected) // deep equality

    Expected: ["__usedExports", "deepEqual", "equal"]
    Received: undefined

__webpack_exports_info__.usedExports is not supported.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Jun 27, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 27, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit ef6b53d
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/667ce33c90b7aa000866199f
😎 Deploy Preview https://deploy-preview-6946--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@h-a-n-a h-a-n-a changed the title fix: context passed in is not correct fix: context passed into the ModuleFactory is not correct Jun 27, 2024
@h-a-n-a h-a-n-a requested a review from JSerFeng June 27, 2024 04:20
@h-a-n-a h-a-n-a enabled auto-merge (squash) June 27, 2024 04:22
@h-a-n-a h-a-n-a merged commit 7afae4d into main Jun 27, 2024
38 checks passed
@h-a-n-a h-a-n-a deleted the fix/context branch June 27, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSerFeng JSerFeng JSerFeng approved these changes

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz jerrykingxyz is a code owner

Assignees

@h-a-n-a h-a-n-a

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@h-a-n-a @JSerFeng