Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: define #95

Merged
merged 1 commit into from May 23, 2022
Merged

feat: define #95

merged 1 commit into from May 23, 2022

Conversation

bvanjoi
Copy link
Collaborator

@bvanjoi bvanjoi commented May 10, 2022

No description provided.

hyf0
hyf0 requested changes May 10, 2022
View reviewed changes
crates/rspack/src/utils/mod.rs Outdated Show resolved Hide resolved
crates/rspack_plugin_define/src/lib.rs Outdated Show resolved Hide resolved
crates/rspack/fixtures/define/index.js Outdated Show resolved Hide resolved
@hyf0 hyf0 mentioned this pull request May 11, 2022
Closed
@hyf0 hyf0 linked an issue May 11, 2022 that may be closed by this pull request
DefinePlugin #84
Closed
@bvanjoi bvanjoi force-pushed the define branch 2 times, most recently from 7f25c42 to 3c9a5aa Compare May 16, 2022 09:44
@h-a-n-a
Copy link
Collaborator

h-a-n-a commented May 19, 2022 •
edited

Could you add some source map tests?

@h-a-n-a h-a-n-a mentioned this pull request May 19, 2022
Closed
3 tasks
@bvanjoi bvanjoi force-pushed the define branch 2 times, most recently from 7ab01b1 to e043037 Compare May 21, 2022 06:21
@bvanjoi
Copy link
Collaborator Author

bvanjoi commented May 21, 2022

Could you add some source map tests?

https://github.com/speedy-js/rspack/pull/95/files#diff-87f172ef3fc421bcbe5f838f1e9732eaf29ea869ea572fddcfd83598ef658a05R515

@bvanjoi bvanjoi force-pushed the define branch 2 times, most recently from 6f0a7cb to 416ef84 Compare May 23, 2022 06:56
@bvanjoi bvanjoi enabled auto-merge (rebase) May 23, 2022 07:42
@h-a-n-a
Copy link
Collaborator

h-a-n-a commented May 23, 2022

cc @iheyunfei

@bvanjoi bvanjoi merged commit 1ea8757 into main May 23, 2022
@bvanjoi bvanjoi deleted the define branch May 23, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underfin underfin underfin left review comments

@h-a-n-a h-a-n-a h-a-n-a approved these changes

@hyf0 hyf0 hyf0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DefinePlugin
4 participants
@bvanjoi @h-a-n-a @underfin @hyf0