fix: sidebar not display using cleanUrls: true when visit with .html …

…suffix (#982)
web-infra-dev · Apr 19, 2024 · 0dea4cb · 0dea4cb
1 parent 2f12415
commit 0dea4cb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/packages/shared/src/runtime-utils/index.test.ts b/packages/shared/src/runtime-utils/index.test.ts
@@ -46,6 +46,7 @@ describe('test shared utils', () => {
   });
 
   test('normalizeHref', () => {
+    expect(normalizeHref()).toEqual('/');
     expect(normalizeHref('/guide/')).toBe('/guide/index.html');
     expect(normalizeHref('/guide')).toBe('/guide.html');
     expect(normalizeHref('/guide/index.html')).toBe('/guide/index.html');
@@ -57,7 +58,10 @@ describe('test shared utils', () => {
       'mailto:bluth@example.com',
     );
     expect(normalizeHref('tel:123456789')).toBe('tel:123456789');
+    expect(normalizeHref('/guide', true)).toBe('/guide');
     expect(normalizeHref('/guide/', true)).toBe('/guide/index');
+    expect(normalizeHref('/guide.html', true)).toBe('/guide');
+    expect(normalizeHref('/guide/index.html', true)).toBe('/guide/index');
     expect(normalizeHref('/guide/version-0.1')).toBe('/guide/version-0.1.html');
     expect(normalizeHref('/guide/version-0.1.html')).toBe(
       '/guide/version-0.1.html',

diff --git a/packages/shared/src/runtime-utils/index.ts b/packages/shared/src/runtime-utils/index.ts
@@ -254,6 +254,10 @@ export function normalizeHref(url?: string, cleanUrls = false) {
     cleanUrl += 'index';
   }
 
+  if (cleanUrls && cleanUrl.endsWith('.html')) {
+    cleanUrl = cleanUrl.replace(/\.html$/, '');
+  }
+
   return addLeadingSlash(hash ? `${cleanUrl}#${hash}` : cleanUrl);
 }