fix(core): duplicate html title tags during ssg (#1194)

web-infra-dev · Jun 19, 2024 · c91f6d3 · c91f6d3
1 parent 8017edd
commit c91f6d3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/e2e/tests/custom-headers.test.ts b/e2e/tests/custom-headers.test.ts
@@ -25,6 +25,14 @@ test.describe('custom headers', async () => {
     }
   });
 
+  test('should render only one title tag during ssg', async ({ page }) => {
+    await page.goto(`http://localhost:${appPort}`, {
+      waitUntil: 'networkidle',
+    });
+    const titleDoms = await page.$$('title');
+    expect(titleDoms.length).toBe(1);
+  });
+
   test('config headers should be injected', async ({ page }) => {
     await page.goto(`http://localhost:${appPort}`, {
       waitUntil: 'networkidle',

diff --git a/packages/core/src/node/build.ts b/packages/core/src/node/build.ts
@@ -157,6 +157,8 @@ export async function renderPages(
 
           const { helmet } = helmetContext.context;
           let html = htmlTemplate
+            // During ssr, we already have the title in react-helmet
+            .replace(/<title>(.*?)<\/title>/gi, '')
             // Don't use `string` as second param
             // To avoid some special characters transformed to the marker, such as `$&`, etc.
             .replace(APP_HTML_MARKER, () => appHtml)