Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: markdown highlight languages #1041

Merged

Conversation

shulaoda
Copy link
Contributor

@shulaoda shulaoda commented Apr 29, 2024

Summary

Related Issue

closes: #1026

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 74c23cc
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/662f5e0b4828a10008285b6b
😎 Deploy Preview https://deploy-preview-1041--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911
Copy link
Collaborator

Awesome! Can you add an e2e fixtures named prism-sytax-highlighter, and write a simple test for this?

@Timeless0911 Timeless0911 merged commit f83a147 into web-infra-dev:main Apr 29, 2024
8 checks passed
@Timeless0911
Copy link
Collaborator

Thank you~

@shulaoda shulaoda deleted the fix/markdown-highlight-languages branch April 29, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: markdown.highlightLanguages config does not take effect
2 participants