Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(style): improve links style in dark mode #1046

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Conversation

chenjiahan
Copy link
Member

Summary

Improve all links style in dark mode.

For link elements, there is new --rp-c-link CSS variable, which use --rp-c-brand-dark in the light mode, and use --rp-c-brand-light in the dark mode. It provides contrast with the background.

  • before:
Screenshot 2024-04-30 at 14 48 46
  • after:
Screenshot 2024-04-30 at 14 48 38

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 8fc2d0d
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/663097e3a5718f0008a702cc
😎 Deploy Preview https://deploy-preview-1046--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 86 (🔴 down 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SoonIter SoonIter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful react blue in the dark 👍🏻

@chenjiahan chenjiahan merged commit 607c6b6 into main Apr 30, 2024
9 checks passed
@chenjiahan chenjiahan deleted the dark_mode_link_0430 branch April 30, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants