Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not generate ssr route runtime module when client build #1087

Merged
merged 1 commit into from
May 17, 2024

Conversation

Timeless0911
Copy link
Collaborator

@Timeless0911 Timeless0911 commented May 17, 2024

Summary

Generate route virtual modules based on isSSR in different build modes.

Not generate ssr route runtime module when client build.

This avoids the SSR routing virtual module generated by client build from affecting the module number calculation of lazy compilation.

When ssr build, the client route runtime module still generated since some route match logic function need this structure.

Related Issue

web-infra-dev/rspack#5915

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented May 17, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 378f582
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/6646f12a2783dd000825ca75
😎 Deploy Preview https://deploy-preview-1087--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (🟢 up 15 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

chenjiahan
chenjiahan previously approved these changes May 17, 2024
@Timeless0911 Timeless0911 force-pushed the fix/generate-runtime-route branch 3 times, most recently from d459c42 to ecc54f5 Compare May 17, 2024 05:45
@Timeless0911 Timeless0911 changed the title fix: generate route runtime module by isSSR fix: not generate ssr route runtime module when client build May 17, 2024
@chenjiahan chenjiahan merged commit 6304571 into main May 17, 2024
10 checks passed
@chenjiahan chenjiahan deleted the fix/generate-runtime-route branch May 17, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants