refactor: remove auto detect esmodule #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 19ac260 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JSerFeng
force-pushed
the
refactor/remove-esm-detect
branch
3 times, most recently
from
d23e953
to
1af6a18
Compare
JSerFeng
force-pushed
the
refactor/remove-esm-detect
branch
from
1af6a18
to
19ac260
Compare
chenjiahan
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the early days, SWC has an issue that is it injected
__esModuleunexpectedly, see here, so at that time, I useis_esmto check if the input code is esModule or not, if it isn't, then__esModuleshould not present in the exports, and I can remove it in the output code.However this detection is not robust enough, it did not take
import.metaandtop-level-awaitinto account, thank @咲奈Sakina for mentioning this.Now, SWC fixed this issue, and we no longer need this behavior.