Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle reattach and changing input #93

Merged
merged 2 commits into from
Nov 5, 2022
Merged

fix: handle reattach and changing input #93

merged 2 commits into from
Nov 5, 2022

Conversation

web-padawan
Copy link
Owner

Description

  1. Moved attachShadow() call to the hex-input constructor to not throw on re-attach,
  2. Fixed slotchange listener to set value on the custom <input> when adding it lazily.

@web-padawan web-padawan merged commit 901150b into master Nov 5, 2022
@web-padawan web-padawan deleted the fix/reattach branch November 5, 2022 09:08
@web-padawan web-padawan mentioned this pull request Nov 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@web-padawan