Create a mouse-events feature
#1263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an old feature, but created to capture
`api.MouseEvent.movement{X,Y}` that, until this commit, were under the
`pointer-lock` feature. The properties work independently of pointer
lock, so it makes sense for them to live somewhere else.
This was prompted by mdn/content#34263.
github-actions
bot
added
the
feature definition
bsmth
reviewed
Jun 19, 2024
| - api.MouseEvent.relatedTarget | ||
| - api.MouseEvent.screenX | ||
| - api.MouseEvent.screenY | ||
| - api.MouseEvent.shiftKey |
There was a problem hiding this comment.
Most of these look good to me based on the spec and looks like everything predating pointer events -> https://www.w3.org/TR/2019/WD-pointerevents3-20191212/#intro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an old feature, but created to capture
api.MouseEvent.movement{X,Y}that were under thepointer-lockfeature. The properties work independently of pointer lock, so it makes sense for them to live somewhere else, with a better support history than pointer lock's.This will need follow up after #1227 (or something like it) merges. See the diff for details.This was prompted by mdn/content#34263
cc: @bsmth