Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dirname #995

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Add dirname #995

merged 1 commit into from
Apr 29, 2024

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Apr 29, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Apr 29, 2024
@@ -0,0 +1,8 @@
name: dirname
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I read the description I though that dirname must have something to do with directory names, since there are many APIs like https://nodejs.org/docs/latest/api/path.html#pathdirnamepath and https://docs.python.org/3/library/os.path.html#os.path.dirname.

But I don't think we should try to disambiguate this, let's see what kind of feedback we get first.

I've done a quick search of https://github.com/w3c/webref and can't find any other web platform features that contain the string "dirname", which is good.

@foolip foolip merged commit 5ddcb7c into web-platform-dx:main Apr 29, 2024
3 checks passed
@ddbeck ddbeck deleted the dirname branch April 29, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants