Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite accessibility/crashtests/svg-mouse-listener.html to avoid timeout #106

Closed
Tracked by #90
cookiecrook opened this issue Feb 6, 2024 · 4 comments
Closed
Tracked by #90

Comments

@cookiecrook
Copy link
Collaborator

cookiecrook commented Feb 6, 2024

@boazsender wrote

The test [@cookiecrook] linked with the timeouts doesn't seem to be one of the B accessibility crash tests (although it's pretty weird that it's timing out across all browsers).

It's timing out because currently crashtests don't support testdriver (see web-platform-tests/wpt#13183 which is mostly about reftests; crashtests are probably slightly easier, but the story is similar).

For now you'd need to rewrite that as a testharness test.

Originally posted by @jgraham in #100 (comment)

@cookiecrook
Copy link
Collaborator Author

cookiecrook commented Feb 14, 2024

@kevers-google @aleventhal FYI your WPT patch via Chromium seems to have broken the WPT results. Do you want to fix it or should we roll out the change?

@kevers-google
Copy link

Sorry for the delayed response. I'll fix the test.

@kevers-google
Copy link

https://chromium-review.googlesource.com/c/chromium/src/+/5348198

This test was the only one in accessibility/crashtests using test-driver. We need async behavior here in order to actually process the click event. Otherwise, we have a memory leak (at least in Blink) due to the unhandled event. In fact, the test as originally authored could end before the synthetic event is even triggered. The solution in review moves the test out of crashtests and converts it to a promise_test.

@kevers-google
Copy link

Believe this issue can now be closed as the relevant test is no longer a crashtest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants