Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolation color space for gradients #109

Closed
nt1m opened this issue Aug 13, 2022 · 17 comments
Closed

Interpolation color space for gradients #109

nt1m opened this issue Aug 13, 2022 · 17 comments
Labels
accepted An accepted proposal focus-area-proposal Focus Area Proposal

Comments

@nt1m
Copy link
Member

nt1m commented Aug 13, 2022

** Test List **

  • css/css-images/gradient/gradient-eval-002.html
  • css/css-images/gradient/gradient-eval-003.html
  • css/css-images/gradient/gradient-eval-005.html
  • css/css-images/gradient/gradient-eval-006.html
  • css/css-images/gradient/gradient-eval-007.html
  • css/css-images/gradient/gradient-eval-008.html
  • css/css-images/gradient/gradient-eval-009.html
  • css/css-images/parsing/gradient-interpolation-method-valid.html
  • css/css-images/parsing/gradient-interpolation-method-invalid.html
  • css/css-images/parsing/gradient-interpolation-method-computed.html

** Rationale **

When I originally audited all the CSS Color tests in #20, I did consider adding these (see follow up comments), though it wasn't clear at the time that:

  1. It would be deemed ready to ship by CSSWG
  2. If other browsers needed some kind of fuzzing

Things are more clear now:

  1. Yes, this feature was deemed ready to ship: [css-color-5][css-images-4] Are these features ready to ship? w3c/csswg-drafts#7310 (comment)
  2. Many tests in the test list need to be changed to fail if the syntax isn't supported (by adding a red background underneath for instance). Also, many tests in the directory test color spaces, so I think we shouldn't need fuzzy matching, but if we do turn out to need it, we can always use our existing fuzzy meta tag.

I don't feel super strongly at this point in the year, I'm mostly filing this issue since to me this seemed more of an unintentional omission than intentional one.

WDYT? @emilio @argyleink

@nt1m nt1m added the test-change-proposal Proposal to add or remove tests for an interop area label Aug 13, 2022
@foolip
Copy link
Member

foolip commented Aug 18, 2022

@sesse WDYT?

@nt1m
Copy link
Member Author

nt1m commented Aug 18, 2022

@emilio @jgraham What do you think?

@sesse
Copy link

sesse commented Aug 19, 2022

The gradient-eval-* parts seem reasonable to me; they're fairly core functionality in the gradient spec. I don't fully understand the gradient-interpolation-method-* tests offhand, so I can't say much about them.

@nt1m
Copy link
Member Author

nt1m commented Aug 30, 2022

@sesse They're about the new syntax that allows specifying the color-space used for interpolation in gradient functions, e.g. linear-gradient(in lch, red, blue) for instance.

@svgeesus
Copy link

svgeesus commented Sep 7, 2022

I agree with the rationale, and am happy to review a PR which adds a red fail if the syntax is unsupported (just an @supports would work there).

@foolip
Copy link
Member

foolip commented Sep 15, 2022

@lilles can you also review you're OK with including these tests in Interop 2022, since you're now reviewing some of the implementation?

@lilles
Copy link
Member

lilles commented Sep 16, 2022

Yes.

@lilles
Copy link
Member

lilles commented Sep 16, 2022

Making sure the tests fail without lab/lch support: https://chromium-review.googlesource.com/c/chromium/src/+/3902032

@foolip
Copy link
Member

foolip commented Sep 16, 2022

@jgraham can you chase someone for a Gecko position?

@emilio
Copy link

emilio commented Oct 6, 2022

Yeah, including these seems ok.

@jensimmons
Copy link
Contributor

It sounds like we are going to add these to Interop 2022. If for some reason we don't, adding for Interop 2023 would be good to do. We haven't filed an issue, however, since it's likely to go into 2022.... but typing out this comment to reserve the possibility of sticking in the 2023 pile for consideration if needed.

@jensimmons jensimmons added the focus-area-proposal Focus Area Proposal label Oct 15, 2022
@nt1m nt1m removed the test-change-proposal Proposal to add or remove tests for an interop area label Oct 20, 2022
@nt1m
Copy link
Member Author

nt1m commented Oct 20, 2022

Let's make this a proposal for next year.

@jensimmons jensimmons changed the title Consider including interpolation color space for gradients Interpolation color space for gradients Nov 9, 2022
@foolip
Copy link
Member

foolip commented Nov 11, 2022

@nt1m since this isn't a focus area proposal, we should handle it like the flex/grid expansion, would you agree?

@nt1m
Copy link
Member Author

nt1m commented Nov 11, 2022

Could go either way, this could perfectly be a new focus area given this is a separate spec (CSS images), but this does also fit into "Color spaces". I have no strong opinion here.

@foolip
Copy link
Member

foolip commented Nov 11, 2022

There are 196 existing tests in "Color Spaces and Functions" and the suggestion is to add 10. That means the worst case reduction in score would be from 100% to 95%.

We have support from representatives of all 3 engines on this thread, so I think we should bring this up in a future meeting to see if we can just label the tests and be done with it. In particular I'd want @jgraham to weigh in then.

@foolip
Copy link
Member

foolip commented Nov 11, 2022

In the MDN short survey on CSS & HTML, "CSS color spaces and functions (color(), lab(), gradients, etc.)" was selected by ~25% of survey takers, putting it in the top third of the 20 options. (There is some uncertainty as with any survey data.)

@foolip
Copy link
Member

foolip commented Feb 1, 2023

Thank you for proposing interpolation color space for gradients for inclusion in Interop 2023.

We are pleased to let you know that this proposal was accepted as part of the Color Spaces and Functions focus area. You can follow the progress of this Focus Area on the Interop 2023 dashboard.

For an overview of our process, see the proposal selection summary. Thank you for contributing to Interop 2023!

Posted on behalf of the Interop team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted An accepted proposal focus-area-proposal Focus Area Proposal
Projects
No open projects
Status: Proposed
Development

No branches or pull requests

7 participants