Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clip-path-polygon-010.html #409

Closed
progers opened this issue Sep 8, 2023 · 4 comments
Closed

Update clip-path-polygon-010.html #409

progers opened this issue Sep 8, 2023 · 4 comments
Labels
focus area: Masking test-change-proposal Proposal to add or remove tests for an interop area

Comments

@progers
Copy link

progers commented Sep 8, 2023

Test List

css/css-masking/clip-path/clip-path-polygon-010.html

Rationale

The spec states:

For elements with associated CSS layout box, the used value for fill-box is content-box and for stroke-box and view-box is border-box.

The test states:

'fill-box' was specified but is not supported for HTML elements. The used value should be 'border-box' for the polygon() function instead.

I think the test is incorrect and the used value should be "content-box". Firefox currently passes this test, while Chromium and Safari fail.

If this test change proposal is accepted, I would like to make the following changes:

  1. Update the test's meta to say The used value should be 'content-box' for the polygon() function instead.
  2. Update the clip-path value to be polygon(-75px -50%, 50% -25px, 25px 150%, -75px 75px) fill-box which makes the existing reference work (and both Chromium and Safari will now pass).

@nt1m @dholbert

@progers progers added the test-change-proposal Proposal to add or remove tests for an interop area label Sep 8, 2023
@dholbert
Copy link

dholbert commented Sep 8, 2023

Seems fine to me; thanks for the heads-up.

Historical note: git blame shows that the test was added 9 years ago, with its current expectation about the used value being border-box.

The spec agreed with it at that point, but it changed 5 years ago to the current text (with content-box as the used value) in w3c/fxtf-drafts@2c7d482

@dholbert
Copy link

dholbert commented Sep 8, 2023

I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1852323 to update Firefox to pass the (amended) test and match the current spec on this.

@nt1m
Copy link
Member

nt1m commented Sep 8, 2023

Sure, seems fine by me

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 8, 2023
See interop-2023 test change proposal:
  web-platform-tests/interop#409

Bug: 1457595
Change-Id: I42e93b76005e277ce5cb6ced021b37855d3e185f
aarongable pushed a commit to chromium/chromium that referenced this issue Sep 11, 2023
See interop-2023 test change proposal:
  web-platform-tests/interop#409

Bug: 1457595
Change-Id: I42e93b76005e277ce5cb6ced021b37855d3e185f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850602
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1194938}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 11, 2023
See interop-2023 test change proposal:
  web-platform-tests/interop#409

Bug: 1457595
Change-Id: I42e93b76005e277ce5cb6ced021b37855d3e185f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850602
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1194938}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 11, 2023
See interop-2023 test change proposal:
  web-platform-tests/interop#409

Bug: 1457595
Change-Id: I42e93b76005e277ce5cb6ced021b37855d3e185f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850602
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1194938}
@progers
Copy link
Author

progers commented Sep 11, 2023

Thanks everyone! This should be fixed with web-platform-tests/wpt@4dd1803

@progers progers closed this as completed Sep 11, 2023
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Sep 28, 2023
…ate with the current spec, a=testonly

Automatic update from web-platform-tests
Bring clip-path-polygon-010.html up-to-date with the current spec

See interop-2023 test change proposal:
  web-platform-tests/interop#409

Bug: 1457595
Change-Id: I42e93b76005e277ce5cb6ced021b37855d3e185f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850602
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1194938}

--

wpt-commits: 4dd18031b2c1975d722f956483a6cd356574629a
wpt-pr: 41889
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Sep 29, 2023
…ate with the current spec, a=testonly

Automatic update from web-platform-tests
Bring clip-path-polygon-010.html up-to-date with the current spec

See interop-2023 test change proposal:
  web-platform-tests/interop#409

Bug: 1457595
Change-Id: I42e93b76005e277ce5cb6ced021b37855d3e185f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850602
Auto-Submit: Philip Rogers <pdrchromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhuchromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
Cr-Commit-Position: refs/heads/main{#1194938}

--

wpt-commits: 4dd18031b2c1975d722f956483a6cd356574629a
wpt-pr: 41889

UltraBlame original commit: e871d3ac80fd42c22403854f51de40a15e7d0c81
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Sep 29, 2023
…ate with the current spec, a=testonly

Automatic update from web-platform-tests
Bring clip-path-polygon-010.html up-to-date with the current spec

See interop-2023 test change proposal:
  web-platform-tests/interop#409

Bug: 1457595
Change-Id: I42e93b76005e277ce5cb6ced021b37855d3e185f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850602
Auto-Submit: Philip Rogers <pdrchromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhuchromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
Cr-Commit-Position: refs/heads/main{#1194938}

--

wpt-commits: 4dd18031b2c1975d722f956483a6cd356574629a
wpt-pr: 41889

UltraBlame original commit: e871d3ac80fd42c22403854f51de40a15e7d0c81
ErichDonGubler pushed a commit to ErichDonGubler/firefox that referenced this issue Sep 30, 2023
…ate with the current spec, a=testonly

Automatic update from web-platform-tests
Bring clip-path-polygon-010.html up-to-date with the current spec

See interop-2023 test change proposal:
  web-platform-tests/interop#409

Bug: 1457595
Change-Id: I42e93b76005e277ce5cb6ced021b37855d3e185f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850602
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1194938}

--

wpt-commits: 4dd18031b2c1975d722f956483a6cd356574629a
wpt-pr: 41889
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Sep 30, 2023
…ate with the current spec, a=testonly

Automatic update from web-platform-tests
Bring clip-path-polygon-010.html up-to-date with the current spec

See interop-2023 test change proposal:
  web-platform-tests/interop#409

Bug: 1457595
Change-Id: I42e93b76005e277ce5cb6ced021b37855d3e185f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850602
Auto-Submit: Philip Rogers <pdrchromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhuchromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
Cr-Commit-Position: refs/heads/main{#1194938}

--

wpt-commits: 4dd18031b2c1975d722f956483a6cd356574629a
wpt-pr: 41889

UltraBlame original commit: e871d3ac80fd42c22403854f51de40a15e7d0c81
Lightning00Blade pushed a commit to Lightning00Blade/wpt that referenced this issue Dec 11, 2023
See interop-2023 test change proposal:
  web-platform-tests/interop#409

Bug: 1457595
Change-Id: I42e93b76005e277ce5cb6ced021b37855d3e185f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850602
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1194938}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus area: Masking test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Development

No branches or pull requests

4 participants