-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update clip-path-polygon-010.html #409
Comments
Seems fine to me; thanks for the heads-up. Historical note: git blame shows that the test was added 9 years ago, with its current expectation about the used value being The spec agreed with it at that point, but it changed 5 years ago to the current text (with |
I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1852323 to update Firefox to pass the (amended) test and match the current spec on this. |
Sure, seems fine by me |
See interop-2023 test change proposal: web-platform-tests/interop#409 Bug: 1457595 Change-Id: I42e93b76005e277ce5cb6ced021b37855d3e185f
See interop-2023 test change proposal: web-platform-tests/interop#409 Bug: 1457595 Change-Id: I42e93b76005e277ce5cb6ced021b37855d3e185f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850602 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1194938}
See interop-2023 test change proposal: web-platform-tests/interop#409 Bug: 1457595 Change-Id: I42e93b76005e277ce5cb6ced021b37855d3e185f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850602 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1194938}
See interop-2023 test change proposal: web-platform-tests/interop#409 Bug: 1457595 Change-Id: I42e93b76005e277ce5cb6ced021b37855d3e185f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850602 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1194938}
Thanks everyone! This should be fixed with web-platform-tests/wpt@4dd1803 |
…ate with the current spec, a=testonly Automatic update from web-platform-tests Bring clip-path-polygon-010.html up-to-date with the current spec See interop-2023 test change proposal: web-platform-tests/interop#409 Bug: 1457595 Change-Id: I42e93b76005e277ce5cb6ced021b37855d3e185f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850602 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1194938} -- wpt-commits: 4dd18031b2c1975d722f956483a6cd356574629a wpt-pr: 41889
…ate with the current spec, a=testonly Automatic update from web-platform-tests Bring clip-path-polygon-010.html up-to-date with the current spec See interop-2023 test change proposal: web-platform-tests/interop#409 Bug: 1457595 Change-Id: I42e93b76005e277ce5cb6ced021b37855d3e185f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850602 Auto-Submit: Philip Rogers <pdrchromium.org> Commit-Queue: Xianzhu Wang <wangxianzhuchromium.org> Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org> Cr-Commit-Position: refs/heads/main{#1194938} -- wpt-commits: 4dd18031b2c1975d722f956483a6cd356574629a wpt-pr: 41889 UltraBlame original commit: e871d3ac80fd42c22403854f51de40a15e7d0c81
…ate with the current spec, a=testonly Automatic update from web-platform-tests Bring clip-path-polygon-010.html up-to-date with the current spec See interop-2023 test change proposal: web-platform-tests/interop#409 Bug: 1457595 Change-Id: I42e93b76005e277ce5cb6ced021b37855d3e185f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850602 Auto-Submit: Philip Rogers <pdrchromium.org> Commit-Queue: Xianzhu Wang <wangxianzhuchromium.org> Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org> Cr-Commit-Position: refs/heads/main{#1194938} -- wpt-commits: 4dd18031b2c1975d722f956483a6cd356574629a wpt-pr: 41889 UltraBlame original commit: e871d3ac80fd42c22403854f51de40a15e7d0c81
…ate with the current spec, a=testonly Automatic update from web-platform-tests Bring clip-path-polygon-010.html up-to-date with the current spec See interop-2023 test change proposal: web-platform-tests/interop#409 Bug: 1457595 Change-Id: I42e93b76005e277ce5cb6ced021b37855d3e185f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850602 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1194938} -- wpt-commits: 4dd18031b2c1975d722f956483a6cd356574629a wpt-pr: 41889
…ate with the current spec, a=testonly Automatic update from web-platform-tests Bring clip-path-polygon-010.html up-to-date with the current spec See interop-2023 test change proposal: web-platform-tests/interop#409 Bug: 1457595 Change-Id: I42e93b76005e277ce5cb6ced021b37855d3e185f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850602 Auto-Submit: Philip Rogers <pdrchromium.org> Commit-Queue: Xianzhu Wang <wangxianzhuchromium.org> Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org> Cr-Commit-Position: refs/heads/main{#1194938} -- wpt-commits: 4dd18031b2c1975d722f956483a6cd356574629a wpt-pr: 41889 UltraBlame original commit: e871d3ac80fd42c22403854f51de40a15e7d0c81
See interop-2023 test change proposal: web-platform-tests/interop#409 Bug: 1457595 Change-Id: I42e93b76005e277ce5cb6ced021b37855d3e185f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850602 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1194938}
Test List
css/css-masking/clip-path/clip-path-polygon-010.html
Rationale
The spec states:
The test states:
I think the test is incorrect and the used value should be "content-box". Firefox currently passes this test, while Chromium and Safari fail.
If this test change proposal is accepted, I would like to make the following changes:
The used value should be 'content-box' for the polygon() function instead
.clip-path
value to bepolygon(-75px -50%, 50% -25px, 25px 150%, -75px 75px) fill-box
which makes the existing reference work (and both Chromium and Safari will now pass).@nt1m @dholbert
The text was updated successfully, but these errors were encountered: