Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable view=test mode in wpt.fyi #190

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Enable view=test mode in wpt.fyi #190

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f686b1
Enable view=test mode in wpt.fyi
jcscottiii Apr 5, 2024
2830349
Update wptfyi_enable_view_eq_test.md
jcscottiii May 14, 2024
3d3d2c5
Update rfcs/wptfyi_enable_view_eq_test.md
jcscottiii May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
38 changes: 38 additions & 0 deletions rfcs/wptfyi_enable_view_eq_test.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
## RFC 190: Enable view=test mode in wpt.fyi

## Summary
This RFC proposes enabling a new "test" view mode. This mode introduces a new method for counting total and failing tests, focusing on a strict pass/fail metric based on subtest counts. It includes frontend modifications to facilitate this change. This is to support this [feature request](https://github.com/web-platform-tests/wpt.fyi/issues/3740).

## Details

### Key Changes
Currently, the feature is behind a feature flag that is set to false by default in production.
* **Frontend Changes:**
No frontend changes. This is will only be reachable by a query parameter that the end user must construct.

### Background about "test" View Mode Behavior
* Test pass is only registered when the number of passed subtests equals the total number of subtests.
* Percentages are not displayed, only raw counts at the directory level.
* Individual test level display:
- Shows "PASS" only when subtest passes equal total subtests.
- Shows "FAIL" when `status == OKAY` but subtest passes do not equal total subtests.
jcscottiii marked this conversation as resolved.
Show resolved Hide resolved
- Existing `STATUS_ABBREVIATIONS` mappings used for other statuses.
- "FAIL" as a fallback for any unmapped statuses.

### How To Test The Change

The feature has been enabled in staging by default so users can try it out.

- Go to any page on https://staging.wpt.fyi that shows test counts
- Add the view=test query parameter to the URL

Examples:
- https://staging.wpt.fyi/results/?label=experimental&label=master&aligned&view=test
- https://staging.wpt.fyi/results/compat?label=experimental&label=master&aligned&view=test
- https://staging.wpt.fyi/results/webstorage?label=experimental&label=master&aligned&view=test


### Risks

1. This new approach has different strengths and weaknesses to the long-standing default subtest view on wpt.fyi.
- Mitigation: The default will remain unchanged to support current workflows and existing links.