Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change autoapprove to use workflow_dispatch #4207

Merged
merged 3 commits into from
May 18, 2023

Conversation

jcscottiii
Copy link
Collaborator

@jcscottiii jcscottiii commented May 18, 2023

Upgrade to pascalgn/automerge-action to v0.15.6

  • Why:
    • Comparison of changes shows (check changes in README.md) that in the latest version of the action you can set the PULL_REQUEST
    • Also, we are leveraging "workflow_dispatch" so we need the latest version because it supports the event (check changes in lib/api.js)

Switch automerge yml to listen for workflow_dispatch.

  • Now what happens:
    • Test Workflow -> Auto approve -> Auto merge

Other changes:

  • Other clarifications on permissions

More about the permissions specified for each workflow

Evidence of it working:

Addresses #4199

jcscottiii and others added 3 commits May 18, 2023 15:33
Upgrade to pascalgn/automerge-action to v0.15.6
- Why:
  - Comparison of changes [shows](pascalgn/automerge-action@135f0bd...v0.15.6#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R212) (check changes in README.md) that in the latest version of the action you can set the PULL_REQUEST
  - Also, we are leveraging "workflow_dispatch" so we need the latest version because it [supports the event](pascalgn/automerge-action@135f0bd...v0.15.6#diff-3814d8caba69e5fdf3b23eed56ec7d708b8ede5aed6d686ac579421877938ec7R107) (check changes in lib/api.js)

Switch automerge yml to listen for workflow_dispatch.
- Now what happens:
  - Test Workflow -> Auto approve -> Auto merge

Other changes:
- Other clarifications on permissions
- Use download artifact instead of script to download artifact
@jcscottiii jcscottiii linked an issue May 18, 2023 that may be closed by this pull request
@jcscottiii jcscottiii merged commit 71c462c into web-platform-tests:master May 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Non manifest PRs are not merging
2 participants