Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update s* from monorail results #829

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Conversation

stephenmcgruer
Copy link
Contributor

See #798 for the methodology

@stephenmcgruer stephenmcgruer added the do not merge yet Disable auto-merge label Feb 5, 2021
sanitizer-api/META.yml Outdated Show resolved Hide resolved
screen-orientation/META.yml Outdated Show resolved Hide resolved
screen-orientation/META.yml Outdated Show resolved Hide resolved
screen-wake-lock/META.yml Outdated Show resolved Hide resolved
scroll-animations/META.yml Outdated Show resolved Hide resolved
streams/readable-byte-streams/META.yml Outdated Show resolved Hide resolved
streams/transform-streams/META.yml Outdated Show resolved Hide resolved
streams/writable-streams/META.yml Outdated Show resolved Hide resolved
svg/animations/META.yml Outdated Show resolved Hide resolved
svg/types/scripted/META.yml Outdated Show resolved Hide resolved
Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some spot checking.

@@ -0,0 +1,12 @@
links:
- product: chrome
url: https://crbug.com/1056055
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a success case, WPT import bug got turned into something more specific.

@foolip
Copy link
Member

foolip commented Feb 15, 2021

@stephenmcgruer oops this conflicts now, sorry for slow review.

See #798 for the methodology
@stephenmcgruer
Copy link
Contributor Author

@stephenmcgruer oops this conflicts now, sorry for slow review.

And it even conflicts with work someone had to do manually :P. I've pushed the branch, one interesting case is svg/path/closepath/META.yml where the script came up with a different bug than the human. I think the script is actually correct here, so I'm keeping the script's bug.

@stephenmcgruer stephenmcgruer removed the do not merge yet Disable auto-merge label Feb 16, 2021
@github-actions github-actions bot merged commit fdb2e07 into master Feb 16, 2021
@github-actions github-actions bot deleted the smcgruer/s-monorail branch February 16, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants