Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing wpt.fyi checks #1457

Closed
foolip opened this issue Sep 2, 2019 · 4 comments
Closed

Missing wpt.fyi checks #1457

foolip opened this issue Sep 2, 2019 · 4 comments
Assignees

Comments

@foolip
Copy link
Member

foolip commented Sep 2, 2019

In web-platform-tests/wpt#18722 the Chrome and Firefox wpt.fyi checks weren't created, either for staging or prod.

Taskcluster as a whole did pass, so it's not because of stability checks failing which I first suspected.

@foolip foolip added this to To do in Regression Detection via automation Sep 2, 2019
@lukebjerring
Copy link
Contributor

@foolip - this is actually working as intended; Taskcluster's use of wpt job ignores any changes to the resources/ directory.

web-platform-tests/wpt#18500 is the "fix", just waiting on review - it is distinguishing the stability check vs single-run cases, and letting idlharness.js trigger a single run.

@foolip
Copy link
Member Author

foolip commented Sep 2, 2019

Oh, so the reason we got Safari results is because we unconditionally run affected tests. (I did that to have results as fast as possible and most PRs do affect tests.)

@stephenmcgruer
Copy link
Contributor

So the only remaining work here would be (if its not already happened) to make Safari runs not run unconditionally? Is that something we want to pursue @foolip or is it time to close this as fixed by #18500 ?

@foolip
Copy link
Member Author

foolip commented Nov 5, 2019

@stephenmcgruer this was resolved the other way around, after web-platform-tests/wpt#18500 touching idlharness.js runs all of the idlharness tests, and https://github.com/web-platform-tests/wpt/pull/19611/checks shows it in action.

@foolip foolip closed this as completed Nov 5, 2019
Regression Detection automation moved this from To do to Done Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants