Iterate keys instead of fetching #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Staging instance deployed by Travis CI! |
|
Staging instance deployed by Travis CI! |
Hexcles
suggested changes
Oct 18, 2018
shared/datastore.go
Outdated
| } else if err != nil { | ||
| return result, err | ||
| } | ||
| if (limit == nil || *limit > len(keys)) && len(keys) < MaxCountMaxValue { |
There was a problem hiding this comment.
We should add an else branch for this if and break the loop there to prevent unnecessary full table scan.
There was a problem hiding this comment.
Done (and other simplification).
Hexcles
approved these changes
Oct 18, 2018
shared/datastore.go
Outdated
| @@ -79,16 +79,12 @@ func LoadTestRunKeys( | |||
| break | |||
| } else if err != nil { | |||
| return result, err | |||
| } else if (limit != nil && *limit <= len(keys)) || len(keys) >= MaxCountMaxValue { | |||
There was a problem hiding this comment.
Nit: can we make the two inequalities of the same direction?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-fixes ##587 without fixed-limiting the key count.
Fixes #671
Fixes #569 and might help #570 too...
Review Information
/api/runs?product=chrome-68