Skip to content

Commit

Permalink
Revert "[ChromeDriver] Support triple click in Chromedriver PerformAc…
Browse files Browse the repository at this point in the history
…tions"

This reverts commit 2576e02f3bddd1e0b8f93fb879e309139add9998.

Reason for revert: This CL is likely the cause of the build failure for test external/wpt/webdriver/tests/release_actions/sequence.py>>test_no_release_mouse_sequence_keeps_dblclick_state, in buildes first occurs in:
https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/91045 and
https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/14964

Original change's description:
> [ChromeDriver] Support triple click in Chromedriver PerformActions
>
> When we are using PerformActions from ChromeDriver to simulate three
> mouse click, it only set the click count to 2, not 3, so this test fails
> third_party/blink/web_tests/external/wpt/webdriver/tests/perform_actions
> /pointer_tripleclick.py.
>
> PerformActions should keep the mouse click count and decide if we should
> increase the count or set to 1 when we have a mouse press based on the
> interval of two mouse presses and difference between the current mouse
> positions and the last one.
>
> Bug: 1119679
> Change-Id: I2b941c5d295cdd457109c8866c55e02bb2360555
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366655
> Reviewed-by: John Chen <johnchen@chromium.org>
> Commit-Queue: Lan Wei <lanwei@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#800201}

TBR=lanwei@chromium.org,johnchen@chromium.org

Change-Id: Ie57866e4aef6ac88eca708a05459032c1fee2128
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1119679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368620
Reviewed-by: Maggie Cai <mxcai@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800511}
  • Loading branch information
Maggie Cai authored and chromium-wpt-export-bot committed Aug 21, 2020
1 parent 030f04c commit 020658e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion webdriver/tests/perform_actions/pointer_tripleclick.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

lots_of_text = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor "\
"incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud "\
"exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat."
" exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat."


def test_tripleclick_at_coordinates(session, mouse_chain):
Expand Down

0 comments on commit 020658e

Please sign in to comment.