Don't fire rel=preload error events for invalid type/media/as attribu…

…tes. This matches other browsers, w3c/preload#155 is the spec issue. There was a test for invalid as values. Differential Revision: https://phabricator.services.mozilla.com/D101243 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1685816 gecko-commit: addf2dba472119be3ff5574ddd0efd3b184fa7c4 gecko-reviewers: smaug
web-platform-tests · Jan 13, 2021 · 11597c2 · 11597c2
1 parent 9f7a32e
commit 11597c2
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/preload/onerror-event.html b/preload/onerror-event.html
@@ -15,7 +15,6 @@
     var trackFailed = false;
     var gibberishFailed = false;
     var fetchFailed = false;
-    var emptyFailed = false;
 </script>
 <link rel=preload href="non-existent/dummy.js" as=script onerror="scriptFailed = true;">
 <link rel=preload href="non-existent/dummy.css" as=style onerror="styleFailed = true;">
@@ -24,9 +23,11 @@
 <link rel=preload href="non-existent/test.mp4" as=video onerror="videoFailed = true;">
 <link rel=preload href="non-existent/test.oga" as=audio onerror="audioFailed = true;">
 <link rel=preload href="non-existent/security/captions.vtt" as=track onerror="trackFailed = true;">
-<link rel=preload href="non-existent/dummy.xml?foo" as=foobarxmlthing onerror="gibberishFailed = true;">
 <link rel=preload href="non-existent/dummy.xml?fetch" as=fetch onerror="fetchFailed = true;">
-<link rel=preload href="non-existent/dummy.xml?empty" onerror="emptyFailed = true;">
+<link rel=preload href="non-existent/dummy.xml?foo" as=foobarxmlthing onerror="assert_unreached('invalid as value should not fire error event')">
+<link rel=preload href="non-existent/dummy.xml?empty" onerror="assert_unreached('empty as value should not fire error event')">
+<link rel=preload href="non-existent/dummy.xml?media" as=style media=print onerror="assert_unreached('non-matching media should not fire error event')">
+<link rel=preload href="non-existent/dummy.xml?media" as=style type='text/html' onerror="assert_unreached('invalid mime type should not fire error event')">
 <body>
 <script>
     setup({single_test: true});
@@ -35,7 +36,7 @@
 
     function check_finished() {
         if (styleFailed && scriptFailed && imageFailed && fontFailed && videoFailed && audioFailed &&
-            trackFailed && !gibberishFailed && fetchFailed && !emptyFailed) {
+            trackFailed && fetchFailed) {
             done();
         }
         iterations++;
@@ -48,9 +49,7 @@
             assert_true(videoFailed, "video triggered error event");
             assert_true(audioFailed, "audio triggered error event");
             assert_true(trackFailed, "track triggered error event");
-            assert_false(gibberishFailed, "gibberish as value did not trigger error event");
             assert_true(fetchFailed, "fetch as triggered error event");
-            assert_false(emptyFailed, "empty as triggered error event");
             done();
         } else {
             step_timeout(check_finished, 500);