Skip to content

Commit

Permalink
Enforce single threaded compositing for WPTs (#41682)
Browse files Browse the repository at this point in the history
* Enforce single threaded compositing for WPTs

We are seeing higher flaky rate at Wptrunner side than blink_wpt_tests.
Disable threaded compositing to align with RWT side behavior, and
see if that fixed the issue.

Bug: 1473779
  • Loading branch information
WeizhongX authored and pull[bot] committed Oct 25, 2023
1 parent 0d069ad commit 1514397
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions tools/wptrunner/wptrunner/browsers/content_shell.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@
ContentShellTestharnessExecutor,
)

ENABLE_THREADED_COMPOSITING_FLAG = '--enable-threaded-compositing'
DISABLE_THREADED_COMPOSITING_FLAG = '--disable-threaded-compositing'
DISABLE_THREADED_ANIMATION_FLAG = '--disable-threaded-animation'


__wptrunner__ = {"product": "content_shell",
"check_args": "check_args",
Expand Down Expand Up @@ -58,6 +62,13 @@ def browser_kwargs(logger, test_type, run_info_data, config, subsuite, **kwargs)
for arg in kwargs.get("binary_args", []):
if arg not in args:
args.append(arg)

# Temporary workaround to align with RWT behavior. Unless a vts explicitly
# enables threaded compositing, we should use single threaded compositing
if ENABLE_THREADED_COMPOSITING_FLAG not in subsuite.config.get("binary_args", []):
args.extend([DISABLE_THREADED_COMPOSITING_FLAG,
DISABLE_THREADED_ANIMATION_FLAG])

for arg in subsuite.config.get("binary_args", []):
if arg not in args:
args.append(arg)
Expand Down

0 comments on commit 1514397

Please sign in to comment.