Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[css-properties-values-api] Absolutize initial <url> values.
The computed value would incorrectly remain relative for the initial value of <url>-registered custom properties. This is because it did not undergo the token-rewriting done for non-initial properties. Since the token-rewriting function was implemented, circumstances have changed a little: there is now a general absolutization mechanism (i.e. StyleBuilderConverter::ConvertRegisteredPropertyVariableData). Therefore, this CL performs the URL absolutization on the CSSValue-level rather than the token level. This automatically also catches the initial-value case. Note that CSSVariableDatas with var()-references would previously "forget" their base URL and TextEncoding when resolved. This didn't matter in practice, because we would already have rewritten the tokens at that point. However, it matters now, since the URL is now made absolute _after_ the CSSVariableData is resolved. Hence, CSSVariableData::CreateResolved has gained the appropriate parameters. R=futhark@chromium.org Bug: 641877 Change-Id: I0fd80664adb49e60df24dcc0e91d23872f61fdb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528188 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#646218}
- Loading branch information